-
Notifications
You must be signed in to change notification settings - Fork 0
feat: update ReplicateStatusCause serialization and worker_api to support new WorkflowError format #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…port new WorkflowError format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the ReplicateStatusCause error handling system to include dataset indices and modifies the worker API to support a new WorkflowError format that accepts multiple causes.
- Adds index parameters to dataset-related error variants to provide better error context
- Replaces custom Serialize derivation with manual implementation for structured error serialization
- Updates worker API to send arrays of errors instead of single error objects
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
pre-compute/src/compute/errors.rs | Adds index parameters to error variants and implements custom serialization with cause/message structure |
pre-compute/src/compute/dataset.rs | Updates dataset methods to accept index parameters and pass them to error constructors |
pre-compute/src/compute/pre_compute_args.rs | Updates error construction calls to include dataset indices |
pre-compute/src/compute/pre_compute_app.rs | Adds enumeration to dataset iteration to provide indices for error reporting |
pre-compute/src/compute/utils/env_utils.rs | Updates test to use new error variant with index parameter |
pre-compute/src/compute/app_runner.rs | Modifies API calls to send arrays of errors instead of single error objects |
pre-compute/src/api/worker_api.rs | Removes ExitMessage struct and updates API to handle arrays of ReplicateStatusCause |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…port new WorkflowError format (#21)
No description provided.