Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub webhooks: be tolerant #341

Merged
merged 2 commits into from
Nov 4, 2022
Merged

GitHub webhooks: be tolerant #341

merged 2 commits into from
Nov 4, 2022

Conversation

danielbeardsley
Copy link
Member

@danielbeardsley danielbeardsley commented Nov 4, 2022 •
edited
Loading

  • Gracefully deal with null pull.body
  • Support parsing larger webhook bodies (we've see pretty big ones)

qa_req 0 - I think there's not much to QA here without actually trying it

@danielbeardsley
Pull model: tolerate null body from github api
a8372ce 
Sometimes body is null if a pull is created with no description it
seems.
@danielbeardsley
Body parser: increase max size of webhook body
be6ba15 
I swear we did this before... but I must be remembering

Sometimes, webhook bodies are bigger than 100kb (the default limit).
Let's bump that to 1MB.
andyg0808
andyg0808 approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@andyg0808 andyg0808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 👍

@danielbeardsley danielbeardsley merged commit 781ea47 into master Nov 4, 2022
@danielbeardsley danielbeardsley deleted the github-webhooks--be-tolerant branch November 4, 2022 21:33
@danielbeardsley danielbeardsley mentioned this pull request Nov 17, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyg0808 andyg0808 andyg0808 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielbeardsley @andyg0808