Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2544 terraform s3 create object #3

Merged
merged 39 commits into from
Jul 17, 2015
Merged

Conversation

m-s-austin
Copy link

This is the new provider and accept test for preloading objects into s3 buckets.

Usage:

resource "aws_s3_bucket" "b" {
    bucket = "my_tf_test_bucket"
    acl = "private"
    tags {
        Name = "My bucket"
        Environment = "Dev"
    }
    force_destroy = true
}

resource "aws_s3_bucket_object" "test_object" {
    depends_on = "aws_s3_bucket.b"
    bucket = "my_tf_test_bucket"
    key = "magic_key"
    source = "crash.log"
}

The acceptance test is still not working properly and I am not 100% sure why yet. I intend to get the golang debugger out and dig into it.

Conflicts:
	builtin/providers/aws/resource_aws_s3_bucket.go
@m-s-austin
Copy link
Author

Here is a linux binary for this version:
https://s3.amazonaws.com/ijoin_fork_terraform_distro/linux_amd64.zip

@m-s-austin
Copy link
Author

Acceptance tests are all running again!

aws_s3_bucket.object_bucket
  provider.aws
aws_s3_bucket_object.object
  aws_s3_bucket.object_bucket
provider.aws
--- PASS: TestAccAWSS3BucketObject_basic (6.00s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    6.010s

@m-s-austin
Copy link
Author

OS X Binaries:
https://s3.amazonaws.com/ijoin_fork_terraform_distro/darwin_amd64.zip

I have updated the binaries with the latest working changes.

@chimmelb
Copy link

+1 on the docs (they look like fine docs, if I understood Go and what you were up to)

@tehnorm
Copy link

tehnorm commented May 26, 2015

@m-s-austin if you've not already make sure to update https://github.com/iJoinSolutions/vagrant/blob/master/ops/README.md with the new location to our build of terraform and any additional details that might be needed.

m-s-austin added a commit that referenced this pull request Jul 17, 2015
@m-s-austin m-s-austin merged commit 7d19ae1 into master Jul 17, 2015
@m-s-austin m-s-austin deleted the 2544-terraform-s3-create-object branch July 17, 2015 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants