fix DDTrackCreatorBase::GetTrackStatesAtCalo #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- treat correctly composite spacepoints (from strip stereo layers) - protect against initialization error - fix logic for backward tracks hitting endcap
andresailer
reviewed
Oct 18, 2017
| for (int iHit = 0; iHit < nHitsTrack; ++iHit) { | ||
| marlintrk->addHit(trkHits[iHit]); | ||
| EVENT::TrackerHit* trkHit = trkHits[iHit] ; | ||
| if( UTIL::BitSet32( trkHit->getType() )[ UTIL::ILDTrkHitTypeBit::COMPOSITE_SPACEPOINT ] ){ //it is a composite spacepoint |
There was a problem hiding this comment.
Why is this necessary, when we get all the hits from the original track? Weren't the hits of the track already added the same way?
There was a problem hiding this comment.
No, this is what you have to do to pass an lcio::TrackerHit that is a spacepoint made from two strip hits to MarlinTrk - see here:
https://github.com/iLCSoft/MarlinTrk/blob/master/src/MarlinTrkUtils.cc#L236-L260
There was a problem hiding this comment.
Then it would be better to change this in the addHit function itself. Avoiding all this code duplication
andresailer
reviewed
Oct 18, 2017
src/DDTrackCreatorBase.cc
Outdated
| //Split it up and add both hits to the MarlinTrk | ||
| const EVENT::LCObjectVec rawObjects = trkHit->getRawHits(); | ||
| for( unsigned k=0; k< rawObjects.size(); k++ ){ | ||
| EVENT::TrackerHit* rawHit = dynamic_cast< EVENT::TrackerHit* >( rawObjects[k] ); |
There was a problem hiding this comment.
static_cast or check rawHit for nullptr, or coverity will complain.
andresailer
reviewed
Oct 18, 2017
src/DDTrackCreatorBase.cc
Outdated
| EVENT::TrackerHit* trkHit = trkHits[iHit] ; | ||
| if( UTIL::BitSet32( trkHit->getType() )[ UTIL::ILDTrkHitTypeBit::COMPOSITE_SPACEPOINT ] ){ //it is a composite spacepoint | ||
| //Split it up and add both hits to the MarlinTrk | ||
| const EVENT::LCObjectVec rawObjects = trkHit->getRawHits(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ENDRELEASENOTES