Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove calls setting default encoding strings that have no effect #25

Merged
merged 3 commits into from
Feb 19, 2024
Merged

Remove calls setting default encoding strings that have no effect #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d2d1f6
Update CI workflow using the clicdp nightlies
tmadlener Feb 19, 2024
9dd2575
Remove function calls that have no effect
tmadlener Feb 19, 2024
9df019e
Remove unnecessary changes
tmadlener Feb 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/DDCaloHitCreator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,6 @@ DDCaloHitCreator::~DDCaloHitCreator()

pandora::StatusCode DDCaloHitCreator::CreateCaloHits(const EVENT::LCEvent *const pLCEvent)
{

//fg: there cannot be any reasonable default for this string - so we set it to sth. that will cause an exception in case
// the cellID encoding string is not in the collection:
UTIL::CellIDDecoder<CalorimeterHit>::setDefaultEncoding("undefined_cellID_encoding:100");

PANDORA_RETURN_RESULT_IF(pandora::STATUS_CODE_SUCCESS, !=, this->CreateECalCaloHits(pLCEvent));
PANDORA_RETURN_RESULT_IF(pandora::STATUS_CODE_SUCCESS, !=, this->CreateHCalCaloHits(pLCEvent));
PANDORA_RETURN_RESULT_IF(pandora::STATUS_CODE_SUCCESS, !=, this->CreateMuonCaloHits(pLCEvent));
Expand Down
5 changes: 0 additions & 5 deletions src/DDSimpleMuonDigi.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,11 +110,6 @@ void DDSimpleMuonDigi::init() {
_nRun = -1;
_nEvt = 0;

//fg: there cannot be any reasonable default for this string - so we set it to sth. that will cause an exception in case
// the cellID encoding string is not in the collection:
UTIL::CellIDDecoder<CalorimeterHit>::setDefaultEncoding("undefined_cellID_encoding:100");


//Get the number of Layers in the Endcap
int layersEndcap=0, layersBarrel=0;

Expand Down
Loading