Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use samesite config setting value #436

Merged
merged 1 commit into from
Jan 2, 2023
Merged

Conversation

Dresdn
Copy link
Contributor

@Dresdn Dresdn commented Sep 29, 2022

Uses the settings.JWT_AUTH_SAMESITE value when deleting cookies, maintaining the consistency of how the cookies were created.

Closes #435

Copy link

@whoismaruf whoismaruf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes 🤝

@loomitz
Copy link

loomitz commented Nov 24, 2022

Thanks, works as expected. This changes correctly cleans cookies when /logout is used

@iMerica
Copy link
Owner

iMerica commented Jan 2, 2023

Thank you for submitting this PR and apologies for the delay.

@iMerica iMerica merged commit cccf816 into iMerica:master Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JWT - /logout Doesn't Delete Cookies
4 participants