Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extras naming with_social -> with-social #635

Merged
merged 1 commit into from
Jul 7, 2024

Conversation

pomali
Copy link
Contributor

@pomali pomali commented May 23, 2024

Replace underscore with hyphen to conform with Core metadata specification https://packaging.python.org/en/latest/specifications/core-metadata/#provides-extra-multiple-use

Found need for this fix because poetry "normalizes" the extras, and when you export requirements.txt from poetry it breaks the extras

@iMerica iMerica merged commit 429a270 into iMerica:master Jul 7, 2024
@Aniket-Singla
Copy link
Contributor

Aniket-Singla commented Jan 1, 2025

I believe this change was not backwards compatible for dependency specifications (eg. requirements.txt). So if people had dj-rest-auth[with_social] even for any previous version of dj-rest-auth prior to this change, I am expecting their builds to fail. But anyways should be a quickfix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants