Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imi fixes #1

Closed
wants to merge 8 commits into from
Closed

Conversation

bst2002git
Copy link

Hello,

i've merged together the actual Magenerds/BasePrice/master with branch imi-fixes and (imi)feature/tier-price, the question is how your feature/tier-price works. I thought i should see some output below the tier-price section in magento 2.3 frontend, but only for the base-price it is outputted. Have a look a the picture (the base-price output still has to be positioned correctly, which is probably due to my theme settings
)
tier-price

How should the tier-price function work?

klg and others added 8 commits March 6, 2019 15:05
…into imi-fixes

Conflicts:
	Block/AfterPrice.php
	Model/Plugin/AfterPrice.php
	view/frontend/templates/afterprice.phtml
	view/frontend/templates/configurable/afterprice.phtml
…asePrice into imi-fixes

Conflicts:
	Block/AfterPrice.php
	Helper/Data.php
@kolaente
Copy link

When a product has tier prices, our fix should show the base price for each tier price. If you customized your theme, you may need to adjust it in a way the tier prices are shown. Can you debug into that?

@kolaente
Copy link

Also our branch imi-fixes is just all four of the PRs we opened at the magenerds repo (Magenerds#43 Magenerds#42 Magenerds#41 Magenerds#39) in one branch so we can use them all at once.

@bst2002git bst2002git closed this Oct 22, 2019
@bst2002git bst2002git deleted the imi-fixes branch October 22, 2019 08:05
@bst2002git bst2002git restored the imi-fixes branch October 22, 2019 08:06
@bst2002git bst2002git deleted the imi-fixes branch October 22, 2019 08:12
@bst2002git
Copy link
Author

When a product has tier prices, our fix should show the base price for each tier price. If you customized your theme, you may need to adjust it in a way the tier prices are shown. Can you debug into that?

Hello,

i think this function should be called in some layout/template file
BasePrice/Block/AfterPrice.php :
public function getTierBasePrices(): array

but only getBasePrice() is called in view/frontend/templates/afterprice.phtml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants