Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SettingsExpander #78

Merged
merged 8 commits into from
Aug 18, 2024
Merged

Add SettingsExpander #78

merged 8 commits into from
Aug 18, 2024

Conversation

swety2003
Copy link
Contributor

No description provided.

@NotYoojun
Copy link
Member

试过能跑不？

NotYoojun
NotYoojun requested changes Aug 12, 2024
View reviewed changes
Copy link
Member

@NotYoojun NotYoojun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a problem:
When the SettingsExpander is expanded, the root CornerRadius is gone.

After fixing this then we can merge

NotYoojun
NotYoojun approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@NotYoojun NotYoojun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SettingExpander seems right now. However there seems to be some issue that is related to the visual states of nested SettingsCard.

I'll try fixing it tomorrow, and then we can merge the this.

Thanks for ur contribution 😁

@NotYoojun NotYoojun merged commit 081a3a6 into iNKORE-NET:main Aug 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotYoojun NotYoojun NotYoojun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swety2003 @NotYoojun