Fix issue with saving firmware files to local machine #2194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe my description of the bug was unclear, so I'd like to explain it again. When you load firmware by using "Load Firmware [Online]" you can download the .hex file to your local machine by clicking on the link in the progress bar (highlighted in the screenshot), it is not working because of outdated Chrome API, in this PR I've fixed it by using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like we had an issue saving downloaded firmware files to a local machine (Because of outdated chrome api). Fixed and tested on MacOS, if it is possible, please check on the other platforms before merging.
Also fixed filename of the files from always "inav.hex" to specific for downloaded firmware.