Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to RX/RC mode handling code #3363

Closed
wants to merge 1 commit into from
Closed

Fixes to RX/RC mode handling code #3363

wants to merge 1 commit into from

Conversation

digitalentity
Copy link
Member

Prevent a scenario where unintended in-air disarm or mode switch may happen if failsafe settings on the receiver were incorrect

@digitalentity
Prohibit BOXmode changes if receiver is not receiving stable signal (…
4a49410 
…except for FAILSAFE mode); Increase default disarm delay to 250ms
@digitalentity digitalentity added Experimental Feedback required The issue/PR is missing information to proceed further Review needed labels Jun 13, 2018
@digitalentity digitalentity added this to the 2.0 milestone Jun 13, 2018
shellixyz added a commit to shellixyz/inav that referenced this pull request Jun 27, 2018
@shellixyz
Squashed commit of the following: upstream/de_rx_fixes (iNavFlight#3363)
6fd52c5 
commit 4a49410
Author: Konstantin Sharlaimov (DigitalEntity) <konstantin.sharlaimov@gmail.com>
Date:   Wed Jun 13 21:04:43 2018 +0200

    Prohibit BOXmode changes if receiver is not receiving stable signal (except for FAILSAFE mode); Increase default disarm delay to 250ms
This was referenced Jun 30, 2018
Merged
Closed
@digitalentity
Copy link
Member Author

@shellixyz did you have a chance to test this? I believe it is ready.

@digitalentity
Copy link
Member Author

For discussion: #3482 makes this PR obsolete in the part that checks for signal stability. After #3482 rcData is always 100% composed of valid updates, failsafe-related channel values won't leak through.

And this makes worth #3478 re-opening and merging.

@stronnag @DzikuVx @fiam

@stronnag
Copy link
Collaborator

I've seen it; this PR was only created because I missed that the new default was in #3363 (mea culpa). It's essential that we nail the SBUS disarm issue in 2.0 in order to maintain user confidence, and I'll defer to your judgement as to the most appropriate solution.

@digitalentity
Copy link
Member Author

@stronnag I believe this is going to be (mostly) deprecated if (or when) we merge the #3482. I suggest we merge your update to default delay ASAP and assess the other changes in due course.

@digitalentity digitalentity deleted the de_rx_fixes branch July 16, 2018 19:05
@digitalentity
Copy link
Member Author

This change is no longer needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Don't merge Experimental Feedback required The issue/PR is missing information to proceed further Testing Required
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@digitalentity @stronnag