Better GPS accuracy reading for FrSky telemetry #3446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@teckel12 Since you're probably the only one using the FrSky telemetry as an API, I think this is safe to merge as soon as it's working for you. Just let us know when it's ready. |
|
@fiam Tested a few times, ready to merge. I didn't change other telemetry protocols that use the same old useless HDOP logic. But my guess is that few if any are looking at it anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the GPS accuracy value being sent to FrSky telemetry was basically useless as an HDOP 10 or less was considered the highest accuracy. Basically, this would cause the GPS accuracy to read either
0, the worst, or9the best.With this change, the GPS accuracy is more granular. A value of
9(the best) is now when the HDOP is 2.0 or less. Each step down for the accuracy value is an HDOP of 0.5 more. So an8is from 2.0 to 2.5,7us from 2.5 to 3.0, etc. with a0being an HDOP higher than 6.0.This change allows for a more useful reporting of the GPS fix accuracy, better informing the pilot of any potential navigation issues.