rangefinder gy-us42 added #5698
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -187,7 +187,7 @@ bool i2cWriteBuffer(I2CDevice device, uint8_t addr_, uint8_t reg_, uint8_t len_, | |||
|
|
|||
| HAL_StatusTypeDef status; | |||
|
|
|||
| if (reg_ == 0xFF && allowRawAccess) { | |||
| if ((reg_ == 0xFF || len_ == 0) && allowRawAccess) { | |||
There was a problem hiding this comment.
STDPeriph I2C driver probably needs patching to allow null writes as well. Can you please check?
There was a problem hiding this comment.
no need to patch "driver/bus_busdev_i2c.c" and "driver/bus_i2c_soft.c" because they are using for-loops based on paramater "len" [... for (i = 0; i < len; i++) { ...]. so it should work... but how can i test it? any other i2c-drivers out there?
|
@emtrax-ltd could you please rebase on top of current |
|
closing as #6792 is in place |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ultrasonic sensor GY-US42 as a new rangefinder to inav.
Because of the sensor's i2c trigger write command (only point to the register and restart), there was the need to patch the Method "drivers/bus_ic2_hal.c-> i2cWriteBuffer(...)" for passing through null values to HAL_I2C_Master_Transmit (raw access).