Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added state NAV_STATE_WAYPOINT_HOVER_ABOVE_HOME #6050

Merged
merged 2 commits into from
Dec 5, 2020

Conversation

Airwide
Copy link
Contributor

@Airwide Airwide commented Aug 15, 2020

This is a pull request to fix issue #4828.

I've tested it successfully on an AR Wing with a MATEKSYS F405 Wing.

It would be great if someone else could validate the functionality on a multicopter.

@Airwide
Copy link
Contributor Author

Airwide commented Sep 3, 2020

@peteoz - I've implemented what you suggested in issue #4828. Can you test on a MR?

@stronnag - I know you work a lot with wp missions. Do you have time to review this pull request and possibly even test it on a MR?

@Airwide
Copy link
Contributor Author

Airwide commented Sep 6, 2020

@DzikuVx - WDYT?

@stronnag
Copy link
Collaborator

stronnag commented Sep 6, 2020

@stronnag - I know you work a lot with wp missions. Do you have time to review this pull request and possibly even test it on a MR?

I should be able to test it in the coming week

@DzikuVx
Copy link
Member

DzikuVx commented Sep 7, 2020

Over here I'm not qualified to say what I think :) @digitalentity ?

@stale
Copy link

stale bot commented Nov 7, 2020

This issue / pull request has been automatically marked as stale because it has not had any activity in 60 days. The resources of the INAV team are limited, and so we are asking for your help.
This issue / pull request will be closed if no further activity occurs within two weeks.

@stale stale bot added the Inactive label Nov 7, 2020
@DzikuVx DzikuVx removed the Inactive label Nov 8, 2020
@Airwide
Copy link
Contributor Author

Airwide commented Nov 9, 2020

@stronnag - Did you manage to test this PR on a MR? Thanks!

@stronnag
Copy link
Collaborator

stronnag commented Nov 9, 2020

Sorry, no I didn't (and not likely to for at least the next 3 weeks)

@Airwide
Copy link
Contributor Author

Airwide commented Nov 24, 2020

@stronnag No worries! I managed to test the PR with my new Pirx Seven drone today. The test was successful and it works as expected. See the transition to Hovering in the screenshot below.

Screenshot 2020-11-24 at 10 51 33

Do you think we need additional tests before this PR can be merged?

@stronnag stronnag added this to the 2.7 milestone Dec 5, 2020
@stronnag
Copy link
Collaborator

stronnag commented Dec 5, 2020

@Airwide if you'd please fix the merge conflict (mea culpa), I'll merge it.

@stronnag stronnag merged commit 18e13c8 into iNavFlight:master Dec 5, 2020
@breadoven breadoven mentioned this pull request Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants