automatically raise BIDIR flag on softserial port if RX and TX pins are set to the same pin #6337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re set to the same pin SoftSerial 1 is using the same pin for TX and RX in FLYWOOF411 target. This allows to have Smartport, SPORT and LTM telemetry on this pin, because they request TX or BIDIR modes from UART. But Mavlink telemetry does not work. It requests full RX & TX mode. Initializing softserial port with pins shared will not do any good anyway: all messages get echoed (I am not even sure it works). Starting port in BIDIR mode is sufficient to have one-directional Mavlink telemetry, and even Bi-directional, if user can setup half-duplex communication. This is better solution for: iNavFlight#5482
shellixyz
requested changes
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SoftSerial 1 is using the same pin for TX and RX in FLYWOOF411 target.
This allows to have Smartport, SPORT and LTM telemetry on this pin, because they request TX or BIDIR modes from UART.
But Mavlink telemetry does not work. It requests full RX & TX mode.
Initializing softserial port with pins shared will not do any good anyway: all messages get echoed (I am not even sure it works).
Starting port in BIDIR mode is sufficient to have one-directional Mavlink telemetry, and even Bi-directional, if user can setup half-duplex communication.
This is better solution for: #5482