-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OSD Stats pages and some crsf formatting fixes #6598
Conversation
Divides disarm stats into pages. Roll stick can be used to go back and forth pages.
Puts Current and Power in one line and moves values one char left as suggested on iNavFlight#6045
To keep inline with other stats
Reverted to separate lines for these values. Will work on reformatting on a separate PR
There is a bug in this PR, or it is incompatible with #6430 which I tested at the same time. If you arm with auto-launch permanently enabled, and you wiggle the sticks to disable auto-launch before take-off, then the disarm screen shows while you are still armed with "DISARMED BY UNKNOWN". |
Weird. I'll test tomorrow. This just splits the original code into two functions. |
Should be fixed now. |
Adds CRSF Min RSSI and LQ to Disarm Stats pages
Added new data as proof of concept. :) |
You have min battery voltage on both pages now. Is that intentional? |
oops, no. I overlooked this when merging two branches. fixed! |
Simplified to make it look pretty
removed a couple of unneeded lines
This is great! Now that there is some free space, I'd like to add a few things from #6548: the option to display cell voltage instead of total battery voltage, and to display both mAh and Wh consumption (could also be an option). Is it okay if I do a PR against your branch? |
Yes sure, go for it and see how it works. |
I probably won't have time to make a PR against your branch in the next week so I think it is best if this is merged so I can make a separate PR later. @DzikuVx? |
Resolves NTSC bug mentioned on #6045
This PR allows to page through OSD Disarm Statistics info and frees lines for other data in the future.
Roll left or right to change pages.