Do not automatically persist the gyro calibration

[DzikuVx]

Connected to #7128
Gyro calibration would be persisted only on "save" command, not after each gyro calibration. Ultimate effect is the same as before but lower the number of config writes

[b14ckyy]

@JulioCesarMatias wanted to make a different change here. He wants to check if the calibration values are 0 and only then save the calibration. If they are not 0 then it won't save again. This would store the gyro calibration one time on a fresh setup and to recalibrate they have to be set to 0 by the user. He just has not made a PR yet before it is properly tested.

[DzikuVx]

This looks like enough and does nor require more changes. Because, when you switch off to on, you have to save either way. That would persist the current calibration. No need for any other checks wt., 12 lip 2022, 11:32 użytkownik b14ckyy ***@***.***> napisał:

…

@JulioCesarMatias <https://github.com/JulioCesarMatias> wanted to make a different change here. He wants to check if the calibration values are 0 and only then save the calibration. If they are not 0 then it won't save again. This would store the gyro calibration one time on a fresh setup and to recalibrate they have to be set to 0 by the user. He just has not made a PR yet before it is properly tested. — Reply to this email directly, view it on GitHub <#8216 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHMBG6F6VG4ALQWOYSWDZTVTU3R3ANCNFSM53KJE6PQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[0crap]

Please consider to remove the auto save from the continous servo trim as well.
Because of the same issue #7128
Thx.

[0crap]

@DzikuVx I compiled a 5.1.0 locally to try things out and still see the below gets changed in my diff all after every plug in.
Sure that is as intended?

set gyro_zero_x = -7
set gyro_zero_y = 21
set gyro_zero_z = -22
set ins_gravity_cmss = 989.691

[b14ckyy]

@0crap yes the values are set in RAM only and that's what you read. But they are not stored to eeprom anymore. If you set init_gyro_cal = OFF then they won't change anymore and use the EEPROM stored values after boot.

[0crap]

@b14ckyy Thx! I made the wrong assumption that if my diff all changed, it also changed my EEPROM.
Glad that is not the case.
I prefer to let my plane calibrate the gyro on every battery. (The way it always has been in iNav.)
So that means I should not set init_gyro_cal = OFF then.
(And live with the fact that if you do a compare of diff all files, the mentioned lines will always show as different.)