-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance Linear Descent RTH feature #8810
Conversation
This PR takes the existing Linear Descent option for RTH and enhances it. Firstly, Linear Descent is now no longer an RTH type. If previously using `AT_LEAST_LINEAR_DESCENT`, you should now just use `AT_LEAST` as the RTH type. Linear Descent is now a separate option that can be used with and other RTH type. To do this, the target altitude of the descent is now the `nav_rth_home_altitude`. In some cases, if flying below the home position, this could even be a linear ascent. An option has also been added to decide how far away the linear descent starts. This is via the `nav_rth_linear_descent_start_distance` parameter. Current behaviour can be maintained by setting this to `0` [default]. You can also specify a distance from home when the descent begins. This is in metres and be up to 10km away. Of course, this value can be adjusted if required.
@MrD-RC The tests of this feature went well with a quad. Setting were - Linear.descent.radius.mp4 |
HITL TestsFirstly, I have to say that with the video capture software running in the background. The flight gets jumpy and the OSD data is a bit laggy. But, the numbers ultimately get hit. Plus, without the capture software, the flight is much more realistic. Linear Descent inactive testsTest 1 -
|
This will need to be 7.0 as it breaks compatibility. I originally set to the 6.1 milestone as there was no 7.0, and I expected 6.1 to just be renamed 7.0. I guess 6.1 will just be a pretty small release. |
Tested in flight. Worked as expected. |
Addresses an issue/request discussed on Discord
This PR takes the existing Linear Descent option for RTH and enhances it. Firstly, Linear Descent is now no longer an RTH type. If previously using
AT_LEAST_LINEAR_DESCENT
, you should now just useAT_LEAST
as the RTH type. Linear Descent is now a separate option that can be used with any other RTH type. To do this, the target altitude of the descent is now thenav_rth_home_altitude
. In some cases, if flying below the home position, this could even be a linear ascent.An option has also been added to decide how far away the linear descent starts. This is via the
nav_rth_linear_descent_start_distance
parameter. Current behaviour can be maintained by setting this to0
[default]. You can also specify a distance from home when the descent begins. This is in metres and be up to 10km. Of course, this value can be adjusted if required.This has been tested in HITL using
AT_LEAST
andMAX
RTH types. There have been tests with linear descent enabled or disabled, and with varying start distances. All test results as expected. I will create some test videos shortly with other RTH types and with RTH Home Altitude set to 0.Configurator
This change require configurator PR iNavFlight/inav-configurator#1727
Options to set up Linear Descent have been added to the Configurator.
![image](https://user-images.githubusercontent.com/17590174/219960364-d11cdf5d-0b51-451d-b068-d52a26221205.png)
If Linear Descent is enabled, and the RTH Home Altitude is less than 10m. A warning is shown around the RTH Home Altitude input box. People can still enter whatever values they want, including 0. If the RTH Home Altitude is not set, Linear Descent is not used in flight.
![image](https://user-images.githubusercontent.com/17590174/219960451-626acd82-c885-4b92-a836-30f3cfc81a41.png)
Fixes #8739