Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSP VTX support #9166

Merged
merged 28 commits into from
Aug 1, 2023
Merged

MSP VTX support #9166

merged 28 commits into from
Aug 1, 2023

Conversation

mmosca
Copy link
Collaborator

@mmosca mmosca commented Jul 8, 2023

Add MSP VTX support

Based on BF's implementation.
Needs new firmware on HD-Zero VTX (hd-zero/hdzero-vtx/pull/141). The current shipping firmware limits MSP-VTX to Betaflight and QuickSilver.

Working:

  • Sends settings to VTX on start up
  • Sends updates when triggered by ELRS
  • Sends updates when using CMS to change settings
  • Sends updates updates when low power state changes

TODO, probably on a follow up pr:

  • Add vtx table to msp vtx, mainly for validating channel and power levels

If you would like to test this, just setup HDZero to use MSP DisplayPort as usual and disable Smart Audio.

mmosca added 22 commits March 8, 2023 21:51
TODO: some of the vtx functions don't do much and may report inacurate
power levels or frequency
Checked hdzero and openvtx implementation and they seen to ignore
frequency and tables. (indexes 5,6,9-14)
MSP message is probably being sent ot the VTX, but is either ignored or
wrong format.

Need to confirm format over the whire and check code in hd-zero vtx.
@mmosca mmosca added this to the 7.0 milestone Jul 11, 2023
@sebas1984x
Copy link

Hi, first of all i would like to thank you for the time making this possible. i really appreciate it.

Changing channels and output power works like a charm when using the ELRS Lua (vtx admin).

i would like to change vtx settings using AUX channels but that doesnt seem to work yet, you can see the settings change in inav but the vtx doesn't change settings.

INAV_7.0.0_cli_20230717_224710.txt

image

@mmosca
Copy link
Collaborator Author

mmosca commented Jul 18, 2023

Hi, first of all i would like to thank you for the time making this possible. i really appreciate it.

Changing channels and output power works like a charm when using the ELRS Lua (vtx admin).

i would like to change vtx settings using AUX channels but that doesnt seem to work yet, you can see the settings change in inav but the vtx doesn't change settings.

INAV_7.0.0_cli_20230717_224710.txt

image

Can you check if it works now?

@sebas1984x
Copy link

Yes, works like a charm.

@mmosca mmosca marked this pull request as ready for review July 26, 2023 21:47
@mmosca mmosca changed the title [WIP] MSP VTX support MSP VTX support Jul 26, 2023
@DzikuVx DzikuVx merged commit 9d450d4 into master Aug 1, 2023
@DzikuVx DzikuVx added the Release Notes Add this when a PR needs to be mentioned in the release notes label Aug 1, 2023
@MartinHugh
Copy link

Add MSP VTX support

Based on BF's implementation. Needs new firmware on HD-Zero VTX (hd-zero/hdzero-vtx/pull/141). The current shipping firmware limits MSP-VTX to Betaflight and QuickSilver.

Working:

  • Sends settings to VTX on start up
  • Sends updates when triggered by ELRS
  • Sends updates when using CMS to change settings
  • Sends updates updates when low power state changes

TODO, probably on a follow up pr:

  • Add vtx table to msp vtx, mainly for validating channel and power levels

If you would like to test this, just setup HDZero to use MSP DisplayPort as usual and disable Smart Audio.

@mmosca thank you for this contribution. Excellent news.

@MrMap
Copy link

MrMap commented Sep 3, 2023

Very happy to learn that MSP-VTX has been merged into the master branch. Acknowledgements and thanks to you guys who did this.

I would really like to test and use it with following setup:
SpeedyBee F405 Wing (currently Inav 6.1.1)
HD Zero Freestyle VTX (currently HDZ_Rev_22082023)
Running Edge TX 2.8.4 with latest ELRS. VTX backpack LUA works fine with HDZ goggles but unreliable with Smart Audio INAV/ VTX.

As I understand it (not being an advanced Github user) I would need to upgrade to current INAV master compiled for the SB F405 Wing target? How do I proceed to obtain this? (I have been reading github docs but still have no confidence in myself to succeed with target build.)

And then I should disable Smart Audio (by deselcting SA as peripheral on the dedicated FC UART port.

  • After this, MSP-VTX should work? (with above mentioned HDZ VTX FW)

Any response / instructions referring to this would be much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Release Notes Add this when a PR needs to be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants