Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Story4 #7

Open
wants to merge 33 commits into
base: main
Choose a base branch
from
Open

Story4 #7

wants to merge 33 commits into from

Conversation

Liamslost
Copy link
Contributor

As an: Amateur Chef
I want: to add an ingredient list to my recipes when creating them
So that: I can quickly see the required ingredients

Requirements:

When adding a recipe, add a section for adding ingredients

each ingredient should be added as a seperate piece of data

unlimited number of ingredients possible

could add zero ingredients

when typing an ingredient in, should match to ingredients from other recipes and auto suggest

ingredients should be displayed against each recipe

Copy link
Collaborator

@mallowmew mallowmew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whenever you Number() an id, you also need to Math.floor() it, in every controller.

You need to isIdValid() whenever you use an id.

main.ts Outdated Show resolved Hide resolved
src/Controllers/addRecipeController.ts Outdated Show resolved Hide resolved
src/Services/validators.ts Outdated Show resolved Hide resolved
src/Controllers/getAllIngredientsController.ts Outdated Show resolved Hide resolved
src/Services/validators.ts Outdated Show resolved Hide resolved
src/controllers/getSingleIngredientController.ts Outdated Show resolved Hide resolved
src/Controllers/addIngredientController.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants