generated from iO-Academy/year-cohort-projectName
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Story4 #7
Open
Liamslost
wants to merge
33
commits into
main
Choose a base branch
from
story4
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mallowmew
requested changes
Dec 12, 2024
mallowmew
requested changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whenever you Number()
an id, you also need to Math.floor()
it, in every controller.
You need to isIdValid()
whenever you use an id.
mallowmew
reviewed
Dec 12, 2024
mallowmew
reviewed
Dec 12, 2024
mallowmew
reviewed
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an: Amateur Chef
I want: to add an ingredient list to my recipes when creating them
So that: I can quickly see the required ingredients
Requirements:
When adding a recipe, add a section for adding ingredients
each ingredient should be added as a seperate piece of data
unlimited number of ingredients possible
could add zero ingredients
when typing an ingredient in, should match to ingredients from other recipes and auto suggest
ingredients should be displayed against each recipe