Error with ! in the title

[ElimGarak72]

🦟 Describe the bug
Hello! First of all, thank you so much for this tool.
I had a subtitle/video with an exclamation point in the title ("2x18 I Drank the Mold!.mkv"). The merge worked but what it came to delete the original video and sub and rename the new video (removing "(1)) the program said it encountered an error and stopped.
I have removed that video from the folder and all the others worked perfectly.

Steps to Reproduce
Steps to reproduce the behavior:

1. Add some files to merge, at least one of them having a "!" in the name.
2. Set the options to "Remove existing subtitles from video before merging new ones", "Remove old video and subtitle files from source directory when finished" and "Remove known advertisement from subtitles before merging".
3. Start the merge.
4. See error when the program tries to delete old video and subtitle files and rename the new one.

Expected behavior
It should show no error and go on with the merging of the other files.

[iPzard]

Trying to reproduce, but everything seems to work for me.. would you mind checking the following and letting me know?

• Are you trying with the latest release?
• Is the video file itself working when you play it?
• If so, is it possible the video file was running in the background while merging?

[ElimGarak72]

Hi Daniel, First of all, thank you for the help. About your questions: 1) I have just downloaded your tool for the first time, it is 2.2.5 which I think is the latest release. 2) I have just tried to play the episode and it works. 3) I was not running the video while merging. This is the error I get. I have tried adding an exclamation point to a title that had worked with no issues and got the same message. So it must have something to do with the exclamation point. I don't know if this could help, but I use Windows with Italian language. Also, I have set your tool with "English" as default track because I watch the videos with English subtitles. Thanks again! Fabio Il 20/11/2021 03:18:32, Daniel W. ***@***.***> ha scritto: Trying to reproduce, but everything seems to work for me.. would you mind checking the following and letting me know? * Are you trying with the latest release [https://github.com/iPzard/mkvtoolnix-batch-tool/releases]? * Is the video file itself working when you play it? * If so, was the video file running in the background while merging? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub [#45 (comment)], or unsubscribe [https://github.com/notifications/unsubscribe-auth/AQB7IYCDBCJT42KLXZMBIZ3UM4HQPANCNFSM5IL6RU3A]. Triage notifications on the go with GitHub Mobile for iOS [https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675] or Android [https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub].

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[ElimGarak72]

Hello Daniel, I have downloaded and installed version 2.3.7. Unfortunately, I get an error with every folder I try to merge. Thank you and have a great day! Fabio Il 15/01/2022 17:51:30, Daniel W. ***@***.***> ha scritto: Closed #45 [#45]. — Reply to this email directly, view it on GitHub [#45 (comment)], or unsubscribe [https://github.com/notifications/unsubscribe-auth/AQB7IYHN6A47PJ52CAIIOC3UWGX2DANCNFSM5IL6RU3A]. Triage notifications on the go with GitHub Mobile for iOS [https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675] or Android [https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub]. You are receiving this because you authored the thread.Message ID: ***@***.***>

[iPzard]

Hey @ElimGarak72, sorry you're having issues. Just have few questions that could help me address this..

• Currently, there is no v2.3.7, do you mean v2.3.1?
• Do all of your folders include files with "!" in the name or is it just failing no matter what the file name is?
• Are you able to provide a copy of one of the subtitle files you're having issues with?

[ElimGarak72]

Hi! 1) You are right, sorry. It is 2.3.0, the latest. I made a mistake because the folder it creates is called 2.3.7. 2) No, it is not a problem related to ! anymore. It happens with all files. 3) You will find it attached, but this happens with every srt (and I have tried idx/sub with the latest version and it is the same) Thank you! Fabio Il 22/01/2022 16:36:26, Daniel W. ***@***.***> ha scritto: Hey @ElimGarak72 [https://github.com/ElimGarak72], sorry you're having issues. Just have few questions that could help me address this.. * Currently, there is no v2.3.7, do you mean v2.3.1? * Do all of your folders include files with "!" in the name or is it just failing no matter what the file name is? * Are you able to provide a copy of one of the subtitle files you're having issues with? — Reply to this email directly, view it on GitHub [#45 (comment)], or unsubscribe [https://github.com/notifications/unsubscribe-auth/AQB7IYBHEFOMSIK6WN6RWNDUXLMITANCNFSM5IL6RU3A]. Triage notifications on the go with GitHub Mobile for iOS [https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675] or Android [https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub]. You are receiving this because you were mentioned.Message ID: ***@***.***>

[iPzard]

Oh wow! Thanks for catching that!! It looks like there's an issue with a newer package I'm using to detect the subtitle language and PyInstaller. I was able to reproduce and fix it locally.. I just updated the release file for 2.3.1.. Hopefully that does it for you too, but let me know if you continue to experience issues.

https://github.com/iPzard/mkvtoolnix-batch-tool/releases

[ElimGarak72]

Hi Daniel, I am so sorry, but it doesn't seem like it solved the issue. Same subtitle I sent you. Could have something to do with the fact that my Windows uses Italian language? Cheers, Fabio Il 22/01/2022 23:03:08, Daniel W. ***@***.***> ha scritto: Oh wow! Thanks for catching that!! It looks like there's an issue [pyinstaller/pyinstaller-hooks-contrib#285] with a newer package I'm using to detect the subtitle language and PyInstaller. I was able to reproduce and fix it locally.. I just updated the release file for 2.3.1.. Hopefully that does it for you too, but let me know if you continue to experience issues. — Reply to this email directly, view it on GitHub [#45 (comment)], or unsubscribe [https://github.com/notifications/unsubscribe-auth/AQB7IYDMYZFSXRAI5THL5ETUXMZSXANCNFSM5IL6RU3A]. Triage notifications on the go with GitHub Mobile for iOS [https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675] or Android [https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub]. You are receiving this because you were mentioned.Message ID: ***@***.***>

[iPzard]

Could you try uninstalling and then reinstalling the program, to ensure a clean install? For the subtitle file.. It doesn't look like an attachment ever made it through here.

[ElimGarak72]

Hi Daniel, I did how you asked. Completely remove (even deleting all registry entries and leftovers) the app and installing the last build. Then I have tried to remove a srt file from a video, but I got this: The properties of the video are as following: I thought maybe the issue was because there were two subtitles. Then I removed one with MKVToolnix and retried. Unfortunately, same error. Then I extracted the remaining subtitle and removed it from the video to try the merge. Yet again... Just to be on the safe side, I have tried merging the video and the subtitle with MKVtooknix and it worked. Thank you! Fabio Il 23/01/2022 05:29:45, Daniel W. ***@***.***> ha scritto: Could you try uninstalling and then reinstalling the program, to ensure a clean install? For the subtitle file.. It doesn't look like an attachment ever made it through here. — Reply to this email directly, view it on GitHub [#45 (comment)], or unsubscribe [https://github.com/notifications/unsubscribe-auth/AQB7IYFEOE7HZWUT6RJUN5LUXOG4RANCNFSM5IL6RU3A]. Triage notifications on the go with GitHub Mobile for iOS [https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675] or Android [https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub]. You are receiving this because you were mentioned.Message ID: ***@***.***>

[iPzard]

I'm not sure why, but looks like the images you're adding to your messages here don't appear. Also, do you have a copy of the subtitle I can take a look at?

[ElimGarak72]

Hello Daniel, I see... Well, anyway they were just for support. I wrote everything. The message is always the same. A pop up with "Error" and "There was an error which prevented the batch from being processed." Thank you! Fabio Il 25/01/2022 17:47:29, Daniel W. ***@***.***> ha scritto: I'm not sure why, but looks like the images you're adding to your messages here don't appear. [Untitled] [https://user-images.githubusercontent.com/8584126/151030987-f25d5ed4-d2cd-4402-83f8-11d6ae348ed7.png] — Reply to this email directly, view it on GitHub [#45 (comment)], or unsubscribe [https://github.com/notifications/unsubscribe-auth/AQB7IYFJZVJSV5JFDIPW2NDUX3O3DANCNFSM5IL6RU3A]. Triage notifications on the go with GitHub Mobile for iOS [https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675] or Android [https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub]. You are receiving this because you were mentioned.Message ID: ***@***.***>

[ElimGarak72]

Hi Daniel! I may be into something about the issue. Today I have tried to use your program dragging the folder into it, but I got the error. However, when i used the "Browse..." button to navigate to the folder, it all worked. Thank you again and have a great day! Cheers, Fabio Il 25/01/2022 17:47:29, Daniel W. ***@***.***> ha scritto: I'm not sure why, but looks like the images you're adding to your messages here don't appear. [Untitled] [https://user-images.githubusercontent.com/8584126/151030987-f25d5ed4-d2cd-4402-83f8-11d6ae348ed7.png] — Reply to this email directly, view it on GitHub [#45 (comment)], or unsubscribe [https://github.com/notifications/unsubscribe-auth/AQB7IYFJZVJSV5JFDIPW2NDUX3O3DANCNFSM5IL6RU3A]. Triage notifications on the go with GitHub Mobile for iOS [https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675] or Android [https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub]. You are receiving this because you were mentioned.Message ID: ***@***.***>

[ElimGarak72]

Hi Daniel, I am afraid you did not receive my last message, so I am writing to you again. I may have found an issue with drag and drop. Today I have tried to use your program dragging the folder into it, but I got the usual error message. However, when i used the "Browse..." button to navigate to the folder, it all worked. Thank you again and have a great day! Cheers, Fabio Message ID: ***@***.***>