Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a new subdomain dev.iscsc.fr to publish in-development features from opened PRs #53

Merged
merged 21 commits into from
May 17, 2024

Conversation

ctmbl
Copy link
Contributor

@ctmbl ctmbl commented Apr 26, 2024

EDIT: see PR has been amputated from the deployment workflow part, #61 will complement it, see #53 (comment) to fully understand

see https://dev.iscsc.fr/

@ctmbl ctmbl added the enhancement New feature or request label Apr 26, 2024
@ctmbl ctmbl requested review from atxr, J3y0 and ZynoXelek April 26, 2024 23:28
@ctmbl ctmbl self-assigned this Apr 26, 2024
@ctmbl ctmbl linked an issue Apr 26, 2024 that may be closed by this pull request
@ctmbl
Copy link
Contributor Author

ctmbl commented May 17, 2024

EDIT: after #53 (comment) this comment doesn't makes sens here and will be moved in the next PR #61

To require manual approval of the deployment of a PR to dev.iscsc.fr I could have used https://github.com/marketplace/actions/manual-workflow-approval but it creates an issue every time such as liquibase/liquibase#5740 which isn't suitable in our case

I preferred to use the GitHub way with Environments and created a deployment-dev environment whihc requires my approval to allow the workflow to run:

@ctmbl ctmbl changed the title Introduce a new subdomain dev.iscsc.fr to publish in-development features from opened PRs [CANCELED] Introduce a new subdomain dev.iscsc.fr to publish in-development features from opened PRs May 17, 2024
@ctmbl ctmbl changed the title [CANCELED] Introduce a new subdomain dev.iscsc.fr to publish in-development features from opened PRs Introduce a new subdomain dev.iscsc.fr to publish in-development features from opened PRs May 17, 2024
@ctmbl
Copy link
Contributor Author

ctmbl commented May 17, 2024

This PR will be amputated from the deploy-dev workflow part 😢

Because I issued this PR from my fork I can't access organization secrets from this PR and then can't test the desired behavior of the workflow I'm introducing here.
see https://github.com/iScsc/blog.iscsc.fr/actions/runs/9133155933/job/25116011582 and https://github.com/iScsc/blog.iscsc.fr/actions/runs/9133155928/job/25116011588 "Debug"
the from ctmbl:dev-subdomain is the pb!

So this PR will be restraint to the update of the nginx config, docker compose and production deployment workflow

@ctmbl ctmbl mentioned this pull request May 17, 2024
8 tasks
@ctmbl
Copy link
Contributor Author

ctmbl commented May 17, 2024

The PR has been heavily tested manually on the server, using the README instruction thoroughly and everything went well

ready to merge ✔️ 🚀

@ctmbl ctmbl merged commit 518225c into iScsc:main May 17, 2024
4 checks passed
@ctmbl ctmbl deleted the dev-subdomain branch May 17, 2024 20:33
ctmbl added a commit to ctmbl/blog.iscsc.fr that referenced this pull request May 17, 2024
ctmbl added a commit to ctmbl/blog.iscsc.fr that referenced this pull request Sep 8, 2024
ctmbl added a commit that referenced this pull request Sep 22, 2024
* TODO pour cette branche

* Add NOTES

* Improve renew certificates instructions

* Improve and adapt README.md to #53

* Add the Feature section

* Add required secret list

* Add links to features

* Improve deployment instructions and add contibuting

* add a toc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy a dev site
1 participant