Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new_article.py script to handle file name containing an Upper Case letter #59

Merged
merged 3 commits into from
May 5, 2024

Conversation

ctmbl
Copy link
Contributor

@ctmbl ctmbl commented May 5, 2024

No description provided.

@ctmbl ctmbl self-assigned this May 5, 2024
@ctmbl
Copy link
Contributor Author

ctmbl commented May 5, 2024

at the time of the first commit the pytest should fail (expected) , the goal of future commits is to make this test pass: this is test-driven development: https://github.com/iScsc/blog.iscsc.fr/actions/runs/8959711589/job/24605420043?pr=59

This first push also highlighted a mistake in the test formulation:

  -         'date': '2024-05-05T12:00:00+02:00',
  ?                            ^
  +         'date': '2024-05-05 12:00:00+02:00',
  ?                            ^
            'draft': False,
  -         'lastUpdate': '2024-05-05T12:00:00+02:00',
  ?                                  ^
  +         'lastUpdate': '2024-05-05 12:00:00+02:00',
  ?                                  ^

The date is wrongly formated

@ctmbl
Copy link
Contributor Author

ctmbl commented May 5, 2024

the wrongly formated test is fixed in 859ead1

See https://github.com/iScsc/blog.iscsc.fr/actions/runs/8959725124/job/24605452002?pr=59

The diff is fine:

   -         'url': 'https://iscsc.fr/posts/article-2',
  ?                                        ^
  +         'url': 'https://iscsc.fr/posts/Article-2',
  ?            

@ctmbl
Copy link
Contributor Author

ctmbl commented May 5, 2024

@ctmbl ctmbl merged commit c4ba0ca into iScsc:main May 5, 2024
4 checks passed
@ctmbl ctmbl deleted the fix-new-article branch May 5, 2024 16:51
@ctmbl ctmbl mentioned this pull request May 5, 2024
@ctmbl ctmbl linked an issue May 7, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix new_article.py script
1 participant