Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Habits Swap Days Displayed When Time-Scrolled While Off-Screen #713

Closed
landry314 opened this issue Jan 17, 2021 · 7 comments
Closed
Labels
bug Something is not behaving as the developers expected confirmed The developers have been able to confirm that the issue is valid
Milestone

Comments

@landry314
Copy link

landry314 commented Jan 17, 2021

Pre-submission checklist

  • [ x] I am submitting a bug report, not a feature request.
  • [ x] I am running the latest version of Loop Habit Tracker.
  • [ x] I have have searched for similar issues, but did not find any matches.

Description

Days temporarily get moved around if you scroll back in time while they are off screen then you bring them back on screen.

Steps to reproduce

  1. Go to main display of all habits
  2. Scroll down so some habits are off screen. Turning into landscape mode can help you have enough habits to accomplish this.
  3. Drag on the list of days to move back in time and reveal older days.
  4. Scroll back up to reveal the habits that were off-screen. Some of them should be shifted a few days off.
  5. To get it back to correct, simply slide the days again, they will fall back in place.

System information

  • Phone: Pixel 3
  • Phone Operating System: Android 11
  • App version: Always newest version. I download releases on github immediately.

This can be confusing to someone, gving false information about a habit. I got quite confused until I figured it out.

@hiqua
Copy link
Collaborator

hiqua commented Jan 18, 2021

Could you add a screenshot of the buggy situation, so that it's easier to understand?

@landry314
Copy link
Author

that's too personal

@landry314
Copy link
Author

you can drag the days to see past days. if you do this while some habits are off screen then you bring them back on screen, they are shifted. try it with staggered habits alternating days. on/off but on different days. you can get it so they are on the same days and simply on the wrong days.

@hiqua
Copy link
Collaborator

hiqua commented Jan 18, 2021

Ok I think I managed to reproduce the bug. So when scrolling back up, the ticks are not refreshed until the days are shifted again. uhabits should not assume that the view previously computed is still valid if the days have been shifted.

Thanks for the report!

@iSoron
Copy link
Owner

iSoron commented Jan 19, 2021

@landry314 Thank you for the bug report. Could you just clarify if this is affecting v1.8.11 or v2.0.0-alpha?

@iSoron iSoron added the bug Something is not behaving as the developers expected label Jan 19, 2021
@landry314
Copy link
Author

1.8.11 is what i am using

@hiqua
Copy link
Collaborator

hiqua commented Jan 19, 2021

Could you just clarify if this is affecting v1.8.11 or v2.0.0-alpha?

I also reproduced it on the last dev version.

@iSoron iSoron added the confirmed The developers have been able to confirm that the issue is valid label Jan 24, 2021
hiqua added a commit to hiqua/uhabits that referenced this issue Jan 28, 2021
@iSoron iSoron added this to the Loop 1.8.12 milestone Jan 29, 2021
hiqua added a commit to hiqua/uhabits that referenced this issue Jan 29, 2021
hiqua added a commit to hiqua/uhabits that referenced this issue Jan 29, 2021
iSoron pushed a commit that referenced this issue Jan 31, 2021
@iSoron iSoron closed this as completed in 2dcce08 Jan 31, 2021
iSoron pushed a commit that referenced this issue Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not behaving as the developers expected confirmed The developers have been able to confirm that the issue is valid
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants