Added delay after toggling a habit and before sorting #1102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iSoron
requested changes
Sep 14, 2021
Comment on lines
126
to
129
| R.id.actionSortColor -> { | ||
| behavior.onSortByColor() | ||
| { behavior.onSortByColor() }.delay(SORT_DELAY_MILLIS) | ||
| return true | ||
| } |
There was a problem hiding this comment.
We don't need to delay the menu actions; changing the order should be done immediately. Could you please remove all calls to delay in this file?
Comment on lines
+92
to
+102
| if (preferences.isSkipEnabled) { | ||
| { | ||
| onToggle(value) | ||
| performHapticFeedback(HapticFeedbackConstants.LONG_PRESS) | ||
| invalidate() | ||
| }.delay(TOGGLE_DELAY_MILLIS) | ||
| } else { | ||
| onToggle(value) | ||
| performHapticFeedback(HapticFeedbackConstants.LONG_PRESS) | ||
| invalidate() | ||
| } |
There was a problem hiding this comment.
- We can apply the delay in all cases (not only when skips are enabled).
- I just realized that this solution unfortunately breaks the ripple effect. The ripple effect should play immediately after the checkmark is entered, but it's currently playing seconds after. I think a better place to add the delay might be around line 143 of HabitCardView.kt.
|
Closing the PR due to inactivity. If you are still working on this, please let me know and I can reopen it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure about the exact delay lengths, these seems fine though. Also, should I add any delay after clicking the "Hide completed" checkbox? Resolves #1055