Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Actions: Enable APIs 30 and 31 #1234

Closed
wants to merge 10 commits into from
Closed

GitHub Actions: Enable APIs 30 and 31 #1234

wants to merge 10 commits into from

Conversation

hiqua
Copy link
Collaborator

@hiqua hiqua commented Dec 11, 2021 •
edited
Loading

Just testing...

@hiqua hiqua force-pushed the gh_action_medium_test_30 branch 3 times, most recently from 3993c99 to 5f620b0 Compare December 11, 2021 15:20
@hiqua hiqua changed the title GitHub Actions: Enable API 30 GitHub Actions: Enable APIs 30 and 31 Dec 11, 2021
@hiqua hiqua marked this pull request as draft December 11, 2021 16:56
@hiqua
Copy link
Collaborator Author

hiqua commented Dec 12, 2021 •
edited
Loading

Getting some flakiness from some text rendered differently (the space between a and y in today is different depending on the API, so kerning behavior has changed).

@hiqua hiqua force-pushed the gh_action_medium_test_30 branch 6 times, most recently from 7910736 to 76f9403 Compare December 13, 2021 21:59
@hiqua
Copy link
Collaborator Author

hiqua commented Jan 9, 2022 •
edited
Loading

As of c44c828, 2 failures each for these tests (flakes) on API 31:

  • testScheduleShowReminder(org.isoron.uhabits.intents.IntentSchedulerTest)
  • shouldExportAndImportBackup(org.isoron.uhabits.acceptance.BackupTest)

@iSoron iSoron mentioned this pull request May 13, 2022
Merged
10 tasks
@iSoron
Copy link
Owner

iSoron commented May 14, 2022 •
edited
Loading

This is now (hopefully) fixed in the branch release/2.1.0. I took some commits from this PR and implemented some new test scripts that allow us to repeat just the failed tests, so flaky tests are no longer such a big issue. PRs to reduce flakiness or increase test speed are still very welcome.

@iSoron iSoron closed this May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiqua @iSoron