doc(WMTSSource): Change the link and the extend to TMSSource #2079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gchoqueux
reviewed
Apr 17, 2023
src/Source/WMTSSource.js
Outdated
| @@ -87,7 +89,8 @@ class WMTSSource extends TMSSource { | |||
| '&REQUEST=GetTile' + | |||
| `&STYLE=${source.style || 'normal'}` + | |||
| `&TILEMATRIXSET=${source.tileMatrixSet}` + | |||
| '&TILEMATRIX=%TILEMATRIX&TILEROW=%ROW&TILECOL=%COL'; | |||
| `&TILEMATRIX=${source.tileMatrix('%TILEMATRIX')}` + | |||
There was a problem hiding this comment.
Why you use a function to set tile matrix identifier?
There was a problem hiding this comment.
According to WMTS standard, the TileMatrix parameter is not always the zoom level. For exemple, for GeoServer, it is the crs concatenate with the zoom level (ex: EPSG:4326:14)
There was a problem hiding this comment.
ok, but the callback doesn't fix it because it calls only one time, when the source is instanced.
There was a problem hiding this comment.
Actually, when i wanted to do. It was possible in TMSSource. I updated the doc, so that WMTSSource extends TMSSource and not Source.
a-dutremble
force-pushed
the
wmts_tileMatrix
branch
from
8c96061 to
3cbb414
Compare
a-dutremble
changed the title
a-dutremble
force-pushed
the
wmts_tileMatrix
branch
from
b6a297d to
aa29f44
Compare
a-dutremble
force-pushed
the
wmts_tileMatrix
branch
from
aa29f44 to
f6f7e19
Compare
mgermerie
approved these changes
Apr 18, 2023
jailln
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is not possible to specify the TileMatrix identifier. In WMTSSource, the identifier corresponds to the zoom level (
%TILEMATRIX). The changes in this PR make it possible to specify a different identifier using a callback function.Motivation and Context
Using other specific sources can be useful. For example, using a WMTS flow from a GeoServer. This allows people who know how to use GetCapabilities to specify a different identifier. This is only a temporary solution. The goal is to automatically implement the retrieval of this information in the GetCapabilities as mentioned in #285.