-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PointMaterial] Custom attenuated points parameters #2171
[PointMaterial] Custom attenuated points parameters #2171
Conversation
2a2a328
to
a925aff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the MR.
Could you clean your commits to only keep the last one. The "package" files shouldn't be edited
This is a nice feature, could you make these parameters (minAdaptiveSize/maxAdaptiveSize/adaptiveScale) editable by the user when he's loading a pointcloud using a C3DTilesLayer? |
Maybe could be a good idea to introduce a parameter |
e702ac1
to
7d0e8a1
Compare
7d0e8a1
to
d7fdc3d
Compare
@AnthonyGlt Thx for your code review. |
489f101
to
721b10e
Compare
Looks good to me. After tests, does it answer your needs ? |
@@ -160,6 +160,7 @@ class PointCloudLayer extends GeometryLayer { | |||
this.material.opacity = this.opacity; | |||
this.material.transparent = this.opacity < 1; | |||
this.material.size = this.pointSize; | |||
this.material.preSSE = context.camera.preSSE; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Desplandis we should implement something similar in C3DTilesLayer
, for now only the default preSSE
value (1.0) will be used in the material when using a C3DTilesLayer, right ?
Concerning this MR, I think your implementation is enough.
Description
Allow custom attenuatedpoints parameters
Motivation and Context
We need to adjust attenuated points parameters for a better rendering in our case.