feat(3dtiles): add method to enable ktx2 loader for gltf #2172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgermerie
reviewed
Aug 28, 2023
src/Parser/B3dmParser.js
Outdated
Comment on lines
79
to
88
| * This library is mandatory to load b3dm and gltf with KTX2 compression. | ||
| * | ||
| * The KTX2 library files are in folder itowns/examples/libs/basis/. | ||
| * You must indicate this path when you want to enable KTX2 decoding. | ||
| * | ||
| * For more information about KTX2, read /itowns/examples/libs/basis/README.md. | ||
| * | ||
| * @example <caption>Enable ktx2 decoder</caption> | ||
| * // if you copied /itowns/examples/libs/draco/ to the root folder of your project,you can set the path to './'. | ||
| * itowns.enableKtx2Loader('./', view.mainLoop.gfxEngine.renderer); | ||
| */ |
There was a problem hiding this comment.
Could you move this part before @params documentation here and for enableDracoLoader ? I just figured that this part would appear in renderer param documentation, as it appears inconfig param doc in enableDracoLoader.
jailln
force-pushed
the
feat/add-ktx2-loader
branch
from
98d993e to
970fc65
Compare
mgermerie
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a method to enable loading of gltf (and 3D tiles) with KTX2 compression. (similar to what was done for draco).
Note: should be moved to
GLTFParseronce #2124 is merged.Motivation and Context
Motivated by #2170