Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fusion get style #2215

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Fusion get style #2215

merged 1 commit into from
Oct 27, 2023

Conversation

ftoromanoff
Copy link
Contributor

@ftoromanoff ftoromanoff commented Oct 23, 2023 •
edited
Loading

This PR aims at merging 2 Style methode that do basicaly the same but on different properties of Style:

  • drawingStylefromContext()
  • symbolStylefromContext()
    into a unique function getStyleFromContext()

A cleanup of the JSDoc of file Style.js has also been conducted.

@ftoromanoff ftoromanoff marked this pull request as draft October 23, 2023 08:54
@ftoromanoff ftoromanoff force-pushed the fusionGetStyle branch 3 times, most recently from 37fe32e to 9f382cf Compare October 25, 2023 09:49
@ftoromanoff ftoromanoff marked this pull request as ready for review October 25, 2023 09:52
@ftoromanoff ftoromanoff force-pushed the fusionGetStyle branch 3 times, most recently from 92149ff to e2bcbb6 Compare October 26, 2023 10:02
@ftoromanoff ftoromanoff requested a review from jailln October 26, 2023 10:04
jailln
jailln reviewed Oct 26, 2023
View reviewed changes
Copy link
Contributor

@jailln jailln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it's clearer this way! thanks also for the doc improvement :)

src/Core/Style.js Outdated Show resolved Hide resolved
@ftoromanoff ftoromanoff merged commit db3e455 into iTowns:master Oct 27, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jailln jailln jailln approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ftoromanoff @jailln