refactor: migrate Coordinates and Ellipsoid to typescript #2437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Desplandis
changed the title
Desplandis
force-pushed
the
ts-migration/coords
branch
4 times, most recently
from
8406a04 to
98fe688
Compare
Desplandis
force-pushed
the
ts-migration/coords
branch
from
98fe688 to
bdcd88a
Compare
Desplandis
force-pushed
the
ts-migration/coords
branch
from
bdcd88a to
84a58e9
Compare
Desplandis
force-pushed
the
ts-migration/coords
branch
from
84a58e9 to
78161ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes:
Coordinatesfrom javascript to typescriptEllipsoidfrom javascript to typescriptProposed breaking type changes:
Three.Vector3, I propose that the constructor ofCoordinatesonly accepts numbers as parameters. We could set from array, coordinates-like objects from corresponding methodssetFromArray()orsetFromVector3. Note that for js users, we would not for now break compatibility (maybe add a depreciation notice).Motivation and Context
As described in proposal #2396, we aim to gradually migrate our entire codebase (with the exception of deprecated modules) from javascript to typescript. We choose to start with modules with no-dependency and move up in the dependency tree.
This PR is the second step of Migrate geographic modules, migrating the both co-dependent modules
CoordinatesandEllipsoid. This PR is a follow-up of #2436.