feat(eslint): remove preference for default export #2447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this PR :) Should we modify all our exports then ? WDYT? |
|
That's the end goal, but I believe we're better off making these changes gradually as we progress through the TS rewrite, essentially grouping edits of the library into isolated chunks per PR instead of one massive sweep. Easier to keep track of and nicer for the |
Ok, fine by me |
jailln
approved these changes
Oct 25, 2024
jailln
pushed a commit
to jailln/itowns
that referenced
this pull request
Oct 30, 2024
Default exports mess with tree shaking and are a source of naming inconsistencies.
jailln
pushed a commit
to jailln/itowns
that referenced
this pull request
Oct 31, 2024
Default exports mess with tree shaking and are a source of naming inconsistencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change ESlint config to remove the preference for default exports.
Also clear a warning caused by unnecessarily quoted object fields in the config.
Motivation and Context
Default exports mess with tree shaking and are generally better avoided.