Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): bump node to next LTS (v22) #2452

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

HoloTheDrunk
Copy link
Contributor

Description

Update the CI's node version to the next LTS version 22.

Motivation and Context

Node version 18 will soon (6 months from now) stop being supported, and some
packages require a higher version.

@HoloTheDrunk HoloTheDrunk changed the title feat(ci): update node to next LTS (v22) feat(ci): bump node to next LTS (v22) Oct 24, 2024
@HoloTheDrunk HoloTheDrunk changed the title feat(ci): bump node to next LTS (v22) ci(node): bump node to next LTS (v22) Oct 24, 2024
@jailln
Copy link
Contributor

jailln commented Oct 24, 2024

Good idea but I remember that @mgermerie started to update it to node 20 and had some issues, see #2268 . For instance commit-message-checker seems to be compatible with node 16 (however the ci works on your PR so it may be a non problem). Can you verify that the listed actions are still working as we expect them to please?

@HoloTheDrunk
Copy link
Contributor Author

HoloTheDrunk commented Oct 24, 2024

(however the ci works on your PR so it may be a non problem)

As far as I can tell the ci forces the actions to run with our specified node version and the PR ones are running properly. I'm unsure how I could test the other actions that are meant to publish the release/package/github pages without catastrophic consequences to be completely honest.

I reckon switching to other, maintained actions would be better done in other PRs, as this one is mainly meant to fix the blocking error on the lru-cache PR.

@jailln
Copy link
Contributor

jailln commented Oct 25, 2024

You can test it on your itowns fork by creating an npm account, configuring your fork to release to npm, opening this PR to your fork and merge it there. Let me know if that works. I can help if needed, I've already done it a few months ago.

@HoloTheDrunk
Copy link
Contributor Author

This has now been tested and everything is working fine! https://github.com/HoloTheDrunk/itowns/actions/runs/11703242249
Seems like it just runs all of them by forcing node 20 and that isn't causing any issues.

@HoloTheDrunk HoloTheDrunk requested a review from jailln November 14, 2024 11:52
@HoloTheDrunk HoloTheDrunk changed the title ci(node): bump node to next LTS (v22) feat(ci): bump node to next LTS (v22) Nov 14, 2024
@HoloTheDrunk HoloTheDrunk merged commit 8df42d2 into iTowns:master Nov 14, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants