Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xbilparser): apply zmin / zmax for any texture subsampling size #2459

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

airnez
Copy link
Contributor

@airnez airnez commented Nov 7, 2024

Description

Min and max clamping elevation parameters were not applied when subsampling parent tile elevation texture with a window smaller that two pixels wide.

This implies that some tiles are not clamped when applying a strong zoom, like switching from the globe view to a city without animation, using STRATEGY_MIN_NETWORK_TRAFFIC. For a custom terrain, setting the usual -99999 nodata value and clamping minimum altitude to 0 results in unexpected culling removing the terrain. See the screenshot.

After looking at git history, I suppose that this might just be a coding mistake, putting these conditions in the wrong code block. What do you think @gchoqueux ?

Screenshots (if appropriate)

zoom-zmin-terrain.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant