use the new JSX transform #2102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayank99
requested review from
r100-stack and
Ben-Pusey-Bentley
and removed request for
a team
Ben-Pusey-Bentley
approved these changes
Jun 13, 2024
r100-stack
reviewed
Jun 13, 2024
packages/itwinui-react/src/utils/components/InputFlexContainer.tsx
Outdated
Show resolved
Hide resolved
r100-stack
reviewed
Jun 13, 2024
| @@ -2,7 +2,7 @@ | |||
| * Copyright (c) Bentley Systems, Incorporated. All rights reserved. | |||
| * See LICENSE.md in the project root for license terms and full copyright notice. | |||
| *--------------------------------------------------------------------------------------------*/ | |||
| import React from 'react'; | |||
| import { useState } from 'react'; | |||
There was a problem hiding this comment.
To confirm, do we want to continue using the default/deconstructed import in react-workshop (similar to #2102 (comment))?
There was a problem hiding this comment.
No, we don't want to use the default import. Not sure where you're getting this idea.
There was a problem hiding this comment.
In #2102 (comment), the codemod changed the itwinui-react code to use deconstructed named imports but then you changed it to use namespace imports. So, I thought should we use default/namespace imports in react-workshop too?
r100-stack
approved these changes
Jun 13, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Builds upon #2100.
I've made a simple change to the
swcconfig to use the new "automatic" JSX runtime instead of "classic". This helps supports React 19, which requires the new JSX transform.I also updated the tsconfig and eslint config to detect the new JSX runtime, and ran the official codemod on the
srcdirectory to fix all imports.Testing
Manually verified that the build output in
esm/cjsfolders is using the new runtime.Also made sure all tests are passing and there are no IDE errors.
Docs
Added changeset.