Added [x]Props for ColorPicker component
#2211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…winUI into uyen/virtualization-bug
r100-stack
reviewed
Sep 3, 2024
Right, I can see that might be too much. |
mayank99
reviewed
Sep 11, 2024
packages/itwinui-react/src/core/ColorPicker/ColorInputPanel.tsx
Outdated
Show resolved
Hide resolved
packages/itwinui-react/src/core/ColorPicker/ColorInputPanel.tsx
Outdated
Show resolved
Hide resolved
mayank99
approved these changes
Sep 12, 2024
r100-stack
reviewed
Sep 13, 2024
packages/itwinui-react/src/core/ColorPicker/ColorPicker.test.tsx
Outdated
Show resolved
Hide resolved
r100-stack
reviewed
Sep 13, 2024
packages/itwinui-react/src/core/ColorPicker/ColorInputPanel.tsx
Outdated
Show resolved
Hide resolved
r100-stack
approved these changes
Sep 13, 2024
r100-stack
approved these changes
Sep 13, 2024
r100-stack
approved these changes
Sep 16, 2024
Merged
32 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added the ability to have custom
propsfor each sub-component ofColorPicker.New props added associated with each sub-component are:
ColorBuilder:colorFieldProps,colorDotProps,opacitySliderProps, andhueSliderProps.ColorInputPanel:panelLabelProps,colorInputContainerProps,inputFieldsGroupProps. andswapColorFormatButtonProps.ColorPalette:labelProps, andpaletteContainerProps.Testing
Added unit tests for the new props listed above.
Docs
Added new changeset.