Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowed assigning PR author in PRs only #2248

Merged
merged 5 commits into from
Sep 18, 2024
Merged

Allowed assigning PR author in PRs only #2248

merged 5 commits into from
Sep 18, 2024

Conversation

smmr-dn
Copy link
Contributor

@smmr-dn smmr-dn commented Sep 17, 2024

Changes

Only allowed assigning author in PR and disabled this CI item from running when the PR is merged (mentioned in this comment #2231 (comment))

Testing

Confirmed that PR author is still assigned in PRs.

Docs

N/A

@smmr-dn smmr-dn changed the title Test workflow Allowed assigning PR author in PRs only Sep 17, 2024
@smmr-dn smmr-dn marked this pull request as ready for review September 18, 2024 14:36
@smmr-dn smmr-dn requested a review from a team as a code owner September 18, 2024 14:36
@smmr-dn smmr-dn requested review from mayank99 and r100-stack and removed request for a team September 18, 2024 14:36
.github/workflows/assign-PR-author.yml Outdated Show resolved Hide resolved
.github/workflows/assign-PR-author.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@mayank99 mayank99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@r100-stack r100-stack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Might be good to link the relevant comment/PR that led to this PR (i.e. #2231 (comment)) in the PR description.

@smmr-dn smmr-dn merged commit 9b38a2c into main Sep 18, 2024
16 of 17 checks passed
@smmr-dn smmr-dn deleted the uyen/move-assign-job branch September 18, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants