Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correction in ProgressLinear JSDocs #2372

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Correction in ProgressLinear JSDocs #2372

merged 1 commit into from
Dec 13, 2024

Conversation

arome
Copy link
Contributor

@arome arome commented Dec 13, 2024 •
edited by r100-stack
Loading

Changes

Small fix in ProgressLinear's JSDocs for its indeterminate prop.

i.e. the prop's default value is true when no value is passed and its default value is false when value is passed. (sandbox)

Testing

N/A

Docs

N/A

@arome arome requested a review from a team as a code owner December 13, 2024 04:38
@arome arome requested review from mayank99 and r100-stack and removed request for a team December 13, 2024 04:38
@r100-stack r100-stack changed the title Update ProgressLinear.tsx Correction in ProgressLinear JSDocs Dec 13, 2024
r100-stack
r100-stack approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@r100-stack r100-stack left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your quick PR! 🚀

To save time, I added a short PR title and description based on your change. Feel free to edit it if needed.

We have some non-required CI steps failing on our end. We will merge the PR soon.

mayank99
mayank99 approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@mayank99 mayank99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@mayank99 mayank99 merged commit 9472c32 into iTwin:main Dec 13, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r100-stack r100-stack r100-stack approved these changes

@mayank99 mayank99 mayank99 approved these changes

Assignees

@arome arome

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arome @mayank99 @r100-stack