Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme bridge to
v5.0.0
#2373base: r/private-css-vars
Are you sure you want to change the base?
Theme bridge to
v5.0.0
#2373Changes from 42 commits
17f2f4d
cd6e72c
7a1a845
44d3e9b
4b0836c
7b35137
950f796
8b213e9
ca20e05
ee51d4b
3303613
ba8e6df
7c778a1
864fbe2
808056b
cd9dedb
a216d1b
666f197
2e3e503
1375402
65a0cba
7733e97
535ff3f
0a3b283
677806b
f987e8b
c1c865b
d5910a4
2be9fa8
1eb5b25
de35da6
c45806f
2eb99bf
4ccd98c
b9d90ce
55fbde0
9307ef9
2199938
3dea59e
a338de9
52020e8
af04c6d
162008f
52252cf
0bcb005
46eb69d
be0762e
1412dac
fc42aea
5ac59aa
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar comment here as Ladle: can we set all attributes on the same element (
<body>
or<html>
) instead of mixing and matching?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iui-root
cannot be onhtml
sinceiui-root
sets afont-size
of0.875rem
(code) which would make the rootfont-size
as0.875rem
and not1rem
.We can set the data attributes on
html
without addingiui-root
as we are currently doing inreact-workshop
for the page background ((code)). However, theniui-root
+ its theme related data attributes will still need to be placed somewhere.To just have one place with the data attributes + the
iui-root
class, we chose<body>
as that place incss-workshop
.Regarding the selected lines, the reason we set
color-scheme
on<html>
and not<body>
is because when placed on<html>
those iTwinUI v5 variables are available throughout the page and not just within🥝-root
.