Skip to content

Commit

Permalink
Switch to dart-sass from deprecated node-sass (#327)
Browse files Browse the repository at this point in the history
* Remove node-sass use in extension-webpack-tools and test-apps
* Fix 'Expected identifier' in transition properties.
* Fix additional 'Expected identifier' in transition properties.
* Fix 'Undefined variable' in mixin default values.

Co-authored-by: Gerardas Butkevicius <10091419+GerardasB@users.noreply.github.com>
  • Loading branch information
calebmshafer and GerardasB authored Dec 11, 2020
1 parent 25b2192 commit 034f56e
Show file tree
Hide file tree
Showing 13 changed files with 410 additions and 808 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "@bentley/extension-webpack-tools",
"comment": "Switch to 'sass' from the now deprecated 'node-sass' package. Switch from fast-sass-loader to sass-loader due to incompatibility with 'sass' and 'fast-sass-loader'",
"type": "none"
}
],
"packageName": "@bentley/extension-webpack-tools",
"email": "31107829+calebmshafer@users.noreply.github.com"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "@bentley/ui-core",
"comment": "",
"type": "none"
}
],
"packageName": "@bentley/ui-core",
"email": "31107829+calebmshafer@users.noreply.github.com"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "@bentley/ui-ninezone",
"comment": "",
"type": "none"
}
],
"packageName": "@bentley/ui-ninezone",
"email": "31107829+calebmshafer@users.noreply.github.com"
}
16 changes: 8 additions & 8 deletions common/config/rush/browser-approved-packages.json
Original file line number Diff line number Diff line change
Expand Up @@ -486,10 +486,6 @@
"name": "faker",
"allowedCategories": [ "backend", "common", "frontend", "internal" ]
},
{
"name": "fast-sass-loader",
"allowedCategories": [ "tools" ]
},
{
"name": "fast-sha256",
"allowedCategories": [ "tools" ]
Expand Down Expand Up @@ -654,10 +650,6 @@
"name": "nock",
"allowedCategories": [ "backend", "common", "integration-testing", "internal" ]
},
{
"name": "node-sass",
"allowedCategories": [ "internal", "tools" ]
},
{
"name": "nodemon",
"allowedCategories": [ "tools" ]
Expand Down Expand Up @@ -866,6 +858,14 @@
"name": "rxjs",
"allowedCategories": [ "frontend" ]
},
{
"name": "sass",
"allowedCategories": [ "internal", "tools" ]
},
{
"name": "sass-loader",
"allowedCategories": [ "tools" ]
},
{
"name": "save",
"allowedCategories": [ "internal" ]
Expand Down
Loading

0 comments on commit 034f56e

Please sign in to comment.