Skip to content

Commit

Permalink
Fix missing iTwinId caching to reduce the frequency of rate limiting (#…
Browse files Browse the repository at this point in the history
…7169)

Co-authored-by: Frank Li <franklbh@users.noreply.github.com>
Co-authored-by: Arun George <11051042+aruniverse@users.noreply.github.com>
  • Loading branch information
3 people committed Sep 19, 2024
1 parent 4e22022 commit 4f58abd
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
4 changes: 3 additions & 1 deletion full-stack-tests/backend/src/HubUtility.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,9 @@ export class HubUtility {
public static async getTestITwinId(accessToken: AccessToken): Promise<GuidString> {
if (undefined !== HubUtility.iTwinId)
return HubUtility.iTwinId;
return HubUtility.getITwinIdByName(accessToken, HubUtility.testITwinName);

HubUtility.iTwinId = await HubUtility.getITwinIdByName(accessToken, HubUtility.testITwinName);
return HubUtility.iTwinId;
}

private static imodelCache = new Map<string, GuidString>();
Expand Down
5 changes: 3 additions & 2 deletions full-stack-tests/core/src/frontend/TestUtility.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@ export class TestUtility {
public static async getTestITwinId(): Promise<GuidString> {
if (undefined !== TestUtility.iTwinId)
return TestUtility.iTwinId;
return TestUtility.queryITwinIdByName(TestUtility.testITwinName);
TestUtility.iTwinId = await TestUtility.queryITwinIdByName(TestUtility.testITwinName);
return TestUtility.iTwinId;
}

public static iTwinPlatformEnv: ITwinPlatformAbstraction;
Expand All @@ -67,7 +68,7 @@ export class TestUtility {
let authorizationClient: AuthorizationClient | undefined;
if (NativeApp.isValid) {
authorizationClient = new ElectronRendererAuthorization(
{clientId: process.env.IMJS_OIDC_ELECTRON_TEST_CLIENT_ID!},
{ clientId: process.env.IMJS_OIDC_ELECTRON_TEST_CLIENT_ID! },
);
IModelApp.authorizationClient = authorizationClient;
const accessToken = await setBackendAccessToken(user);
Expand Down

0 comments on commit 4f58abd

Please sign in to comment.