UI/opt in widget fade #3904
Merged
UI/opt in widget fade #3904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when the rest of the viewport ui hides.
pmconne
approved these changes
Jul 7, 2022
…njs-core into ui/opt-in-widget-fade
whenever the widget's active tab has the setting hideWithUiWhenFloating
GerardasB
approved these changes
Jul 13, 2022
ui/appui-layout-react/src/appui-layout-react/base/NineZoneState.ts
Outdated
Show resolved
Hide resolved
ui/appui-layout-react/src/appui-layout-react/base/NineZoneState.ts
Outdated
Show resolved
Hide resolved
ui/appui-layout-react/src/appui-layout-react/widget/FloatingWidget.tsx
Outdated
Show resolved
Hide resolved
ui/appui-layout-react/src/appui-layout-react/widget/FloatingWidget.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the hideWithUiWhenFloating prop to AbstractWidgetProperties. Any floating widgets with this prop set to true (the default is false) will fade out when the UI automatically hides.
Also, add a note to NextVersion.md about the "use tool name as Tool Settings title" feature added in this PR: #3814