Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade @itwin/eslint-plugin to 4.0.x stable (backport #6703) [release/4.6.x] #6704

Merged
merged 3 commits into from
May 8, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 8, 2024

Upgrade our eslint-plugin package to latest stable version (4.0.2). This update requires extension APIs to be tagged as @public (in addition the the @extensions tag).

Per that requirement, we've decided to hold off on exporting the new Annotation APIs as Extension APIs. In addition, two existing APIs using extensions have been promoted from beta to public - QPoint2dBufferBuilderOptions and QPoint3dBufferBuilderOptions.

Usage of the @preview tag for extensions is no longer supported. No APIs were tagged as such, except for the aforementioned Annotation functionality (which was tagged with both @preview and @beta to support the now-old eslint rule requiring extensions to be preview or public). Functionality relating to preview extension APIs has been removed.


This is an automatic backport of pull request #6703 done by Mergify.

Co-authored-by: Ben Polinsky <ben-polinsky@users.noreply.github.com>
(cherry picked from commit 34079d4)

# Conflicts:
#	common/config/rush/pnpm-lock.yaml
@mergify mergify bot added the conflicts label May 8, 2024
@mergify mergify bot requested review from a team and aruniverse as code owners May 8, 2024 17:21
@mergify mergify bot requested a review from calebmshafer as a code owner May 8, 2024 17:21
Copy link
Contributor Author

mergify bot commented May 8, 2024

Cherry-pick of 34079d4 has failed:

On branch mergify/bp/release/4.6.x/pr-6703
Your branch is up to date with 'origin/release/4.6.x'.

You are currently cherry-picking commit 34079d45bc.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .vscode/cSpell.json
	new file:   common/changes/@itwin/analytical-backend/upgrade-itwin-eslint-4_2024-05-08-16-38.json
	new file:   common/changes/@itwin/appui-abstract/upgrade-itwin-eslint-4_2024-05-08-16-38.json
	new file:   common/changes/@itwin/build-tools/upgrade-itwin-eslint-4_2024-05-08-16-38.json
	new file:   common/changes/@itwin/certa/upgrade-itwin-eslint-4_2024-05-08-16-38.json
	new file:   common/changes/@itwin/core-backend/upgrade-itwin-eslint-4_2024-05-08-16-38.json
	new file:   common/changes/@itwin/core-bentley/upgrade-itwin-eslint-4_2024-05-08-16-38.json
	new file:   common/changes/@itwin/core-common/upgrade-itwin-eslint-4_2024-05-08-16-38.json
	new file:   common/changes/@itwin/core-electron/upgrade-itwin-eslint-4_2024-05-08-16-38.json
	new file:   common/changes/@itwin/core-extension/upgrade-itwin-eslint-4_2024-05-08-16-38.json
	new file:   common/changes/@itwin/core-frontend/upgrade-itwin-eslint-4_2024-05-08-16-38.json
	new file:   common/changes/@itwin/core-geometry/upgrade-itwin-eslint-4_2024-05-08-16-38.json
	new file:   common/changes/@itwin/core-i18n/upgrade-itwin-eslint-4_2024-05-08-16-38.json
	new file:   common/changes/@itwin/core-markup/upgrade-itwin-eslint-4_2024-05-08-16-38.json
	new file:   common/changes/@itwin/core-mobile/upgrade-itwin-eslint-4_2024-05-08-16-38.json
	new file:   common/changes/@itwin/core-orbitgt/upgrade-itwin-eslint-4_2024-05-08-16-38.json
	new file:   common/changes/@itwin/core-quantity/upgrade-itwin-eslint-4_2024-05-08-16-38.json
	new file:   common/changes/@itwin/core-telemetry/upgrade-itwin-eslint-4_2024-05-08-16-38.json
	new file:   common/changes/@itwin/core-webpack-tools/upgrade-itwin-eslint-4_2024-05-08-16-38.json
	new file:   common/changes/@itwin/ecschema-editing/upgrade-itwin-eslint-4_2024-05-08-16-38.json
	new file:   common/changes/@itwin/ecschema-locaters/upgrade-itwin-eslint-4_2024-05-08-16-38.json
	new file:   common/changes/@itwin/ecschema-metadata/upgrade-itwin-eslint-4_2024-05-08-16-38.json
	new file:   common/changes/@itwin/ecschema-rpcinterface-common/upgrade-itwin-eslint-4_2024-05-08-16-38.json
	new file:   common/changes/@itwin/ecschema-rpcinterface-impl/upgrade-itwin-eslint-4_2024-05-08-16-38.json
	new file:   common/changes/@itwin/ecschema-rpcinterface-tests/upgrade-itwin-eslint-4_2024-05-08-16-38.json
	new file:   common/changes/@itwin/ecschema2ts/upgrade-itwin-eslint-4_2024-05-08-16-38.json
	new file:   common/changes/@itwin/ecsql-common/upgrade-itwin-eslint-4_2024-05-08-16-38.json
	new file:   common/changes/@itwin/editor-backend/upgrade-itwin-eslint-4_2024-05-08-16-38.json
	new file:   common/changes/@itwin/editor-common/upgrade-itwin-eslint-4_2024-05-08-16-38.json
	new file:   common/changes/@itwin/editor-frontend/upgrade-itwin-eslint-4_2024-05-08-16-38.json
	new file:   common/changes/@itwin/express-server/upgrade-itwin-eslint-4_2024-05-08-16-38.json
	new file:   common/changes/@itwin/frontend-devtools/upgrade-itwin-eslint-4_2024-05-08-16-38.json
	new file:   common/changes/@itwin/frontend-tiles/upgrade-itwin-eslint-4_2024-05-08-16-38.json
	new file:   common/changes/@itwin/hypermodeling-frontend/upgrade-itwin-eslint-4_2024-05-08-16-38.json
	new file:   common/changes/@itwin/linear-referencing-backend/upgrade-itwin-eslint-4_2024-05-08-16-38.json
	new file:   common/changes/@itwin/linear-referencing-common/upgrade-itwin-eslint-4_2024-05-08-16-38.json
	new file:   common/changes/@itwin/map-layers-auth/upgrade-itwin-eslint-4_2024-05-08-16-38.json
	new file:   common/changes/@itwin/map-layers-formats/upgrade-itwin-eslint-4_2024-05-08-16-38.json
	new file:   common/changes/@itwin/perf-tools/upgrade-itwin-eslint-4_2024-05-08-16-38.json
	new file:   common/changes/@itwin/physical-material-backend/upgrade-itwin-eslint-4_2024-05-08-16-38.json
	new file:   common/changes/@itwin/presentation-backend/upgrade-itwin-eslint-4_2024-05-08-16-38.json
	new file:   common/changes/@itwin/presentation-common/upgrade-itwin-eslint-4_2024-05-08-16-38.json
	new file:   common/changes/@itwin/presentation-frontend/upgrade-itwin-eslint-4_2024-05-08-16-38.json
	new file:   common/changes/@itwin/rpcinterface-full-stack-tests/upgrade-itwin-eslint-4_2024-05-08-16-38.json
	new file:   common/changes/@itwin/webgl-compatibility/upgrade-itwin-eslint-4_2024-05-08-16-38.json
	new file:   common/changes/@itwin/workspace-editor/upgrade-itwin-eslint-4_2024-05-08-16-38.json
	modified:   core/backend/package.json
	modified:   core/bentley/package.json
	modified:   core/common/eslint.config.js
	modified:   core/common/package.json
	modified:   core/common/src/QPoint.ts
	modified:   core/common/src/annotation/TextAnnotation.ts
	modified:   core/common/src/annotation/TextBlock.ts
	modified:   core/common/src/annotation/TextBlockGeometryProps.ts
	modified:   core/common/src/annotation/TextStyle.ts
	modified:   core/common/src/geometry/ElementGeometry.ts
	modified:   core/common/src/geometry/GeometryStream.ts
	modified:   core/ecschema-editing/package.json
	modified:   core/ecschema-locaters/package.json
	modified:   core/ecschema-metadata/package.json
	modified:   core/ecschema-rpc/common/package.json
	modified:   core/ecschema-rpc/impl/package.json
	modified:   core/ecsql/common/package.json
	modified:   core/electron/package.json
	modified:   core/express-server/package.json
	modified:   core/extension/codeGen/generate-exports.js
	modified:   core/extension/eslint.config.js
	modified:   core/extension/package.json
	deleted:    core/extension/preview.d.ts
	deleted:    core/extension/preview.js
	modified:   core/frontend-devtools/package.json
	modified:   core/frontend/eslint.config.js
	modified:   core/frontend/package.json
	modified:   core/frontend/src/extension/ExtensionRuntime.ts
	modified:   core/geometry/package.json
	modified:   core/hypermodeling/package.json
	modified:   core/i18n/package.json
	modified:   core/markup/package.json
	modified:   core/mobile/package.json
	modified:   core/orbitgt/package.json
	modified:   core/quantity/package.json
	modified:   core/telemetry/package.json
	modified:   core/webgl-compatibility/package.json
	modified:   docs/learning/guidelines/release-tags-guidelines.md
	modified:   domains/analytical/backend/package.json
	modified:   domains/linear-referencing/backend/package.json
	modified:   domains/linear-referencing/common/package.json
	modified:   domains/physical-material/backend/package.json
	modified:   editor/backend/package.json
	modified:   editor/common/package.json
	modified:   editor/frontend/package.json
	modified:   example-code/app/package.json
	modified:   example-code/snippets/package.json
	modified:   extensions/frontend-tiles/package.json
	modified:   extensions/map-layers-auth/package.json
	modified:   extensions/map-layers-formats/package.json
	modified:   extensions/test-extension/package.json
	modified:   full-stack-tests/backend/package.json
	modified:   full-stack-tests/core/package.json
	modified:   full-stack-tests/ecschema-rpc-interface/package.json
	modified:   full-stack-tests/presentation/package.json
	modified:   full-stack-tests/rpc-interface/package.json
	modified:   full-stack-tests/rpc/package.json
	modified:   presentation/backend/package.json
	modified:   presentation/common/package.json
	modified:   presentation/frontend/package.json
	modified:   test-apps/display-performance-test-app/package.json
	modified:   test-apps/display-test-app/package.json
	modified:   test-apps/export-gltf/package.json
	modified:   test-apps/imjs-importer/package.json
	modified:   test-apps/imodel-from-geojson/package.json
	modified:   test-apps/imodel-from-orbitgt/package.json
	modified:   test-apps/imodel-from-reality-model/package.json
	modified:   tools/build/package.json
	modified:   tools/build/scripts/utils/validateTags.js
	modified:   tools/certa/package.json
	modified:   tools/ecschema2ts/package.json
	modified:   tools/perf-tools/package.json
	modified:   tools/webpack-core/package.json
	modified:   ui/appui-abstract/package.json
	modified:   utils/workspace-editor/package.json

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   common/config/rush/pnpm-lock.yaml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@ben-polinsky ben-polinsky enabled auto-merge (squash) May 8, 2024 18:23
@aruniverse aruniverse disabled auto-merge May 8, 2024 19:15
@aruniverse aruniverse merged commit 5b6a034 into release/4.6.x May 8, 2024
17 checks passed
@aruniverse aruniverse deleted the mergify/bp/release/4.6.x/pr-6703 branch May 8, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants