-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade @itwin/eslint-plugin to 4.0.x stable (backport #6703) [release/4.6.x] #6704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ben Polinsky <ben-polinsky@users.noreply.github.com> (cherry picked from commit 34079d4) # Conflicts: # common/config/rush/pnpm-lock.yaml
Cherry-pick of 34079d4 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
mergify
bot
requested review from
wgoehrig,
ben-polinsky,
bbastings,
a team,
Ellord207,
paulius-valiunas,
jchick-bentley,
ColinKerr,
diegoalexdiaz,
pmconne,
dassaf4,
saeeedtorabi,
danieliborra,
GytisCepk,
christophermlawson,
naveedkhan8067,
StefanApfel-Bentley and
khanaffan
as code owners
May 8, 2024 17:21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade our eslint-plugin package to latest stable version (4.0.2). This update requires extension APIs to be tagged as
@public
(in addition the the@extensions
tag).Per that requirement, we've decided to hold off on exporting the new Annotation APIs as Extension APIs. In addition, two existing APIs using extensions have been promoted from beta to public -
QPoint2dBufferBuilderOptions
andQPoint3dBufferBuilderOptions
.Usage of the
@preview
tag for extensions is no longer supported. No APIs were tagged as such, except for the aforementioned Annotation functionality (which was tagged with both@preview
and@beta
to support the now-old eslint rule requiring extensions to be preview or public). Functionality relating to preview extension APIs has been removed.This is an automatic backport of pull request #6703 done by Mergify.