Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SheetIndex APIs #6992

Merged
merged 63 commits into from
Sep 30, 2024
Merged

SheetIndex APIs #6992

merged 63 commits into from
Sep 30, 2024

Conversation

Ellord207
Copy link
Contributor

@Ellord207 Ellord207 commented Jul 22, 2024

Context:

My team is working on creating features to facilitate the production of 2d drawings and sheets for users using iTwin.js. To do this, we need to be able to insert Sheet Indexes and their relational elements into the iModel. Since there are no Sheet Index TS implementations, we took the initiative and started creating them ourselves.

I have created an accompanying Discussion Post as a more appropriate place for this discussion.

Description

After discussions, I am intending this PR to include the basic implementations for the Sheet Index. This including backend Classes, common props, Codes, and tests.

After more discussion, future PR(s) will follow to answer the following questions:

  • How to ensure a consistent order of the Sheet Index Entries during editing, specifically including when using SheetIndexReferences among other scenarios.
  • How to automatically generate and update sheet labels/page numbers during editing.
  • Enforcing the 1 SheetReference per Sheet rule.
  • And possibly other limitations to ensure consistency across the platform.

@pmconne pmconne changed the title TS Implementation for Sheet Indexes SheetIndex APIs Sep 27, 2024
@pmconne pmconne enabled auto-merge (squash) September 30, 2024 19:44
@pmconne pmconne enabled auto-merge (squash) September 30, 2024 19:51
@pmconne pmconne merged commit 9f904bc into master Sep 30, 2024
16 checks passed
@pmconne pmconne deleted the add-sheet-index branch September 30, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants