Add polygon selection option to SelectTool #7001
Conversation
saaaaaally
commented
Jul 24, 2024
saaaaaally
commented
- Add new option for polygon selection in SelectTool.
- Add keyin in SelectTool to allow testing of all different selection methods (box, line, pick, polygon)
saaaaaally
requested review from
bbastings,
aruniverse,
ben-polinsky and
a team
as code owners
|
Who is asking for this? |
| ecfPts.push(ecfPt.toJSONXYZ() as XYAndZ); | ||
| ecfXYZPts.push(ecfPt.toJSONXYZ() as XYAndZ); | ||
|
|
||
| if (this.iModel.isGeoLocated) { |
There was a problem hiding this comment.
This is certainly not correct/needed? Why is this geo located specific code here?
This is part of the inspection workflow in iTwin Experience, for improving ai detection crack selection.
|
|
"This is part of the inspection workflow in iTwin Experience, for improving ai detection crack selection. [Feature 1394017]" I suspect this won't be very robust for that use case. Because select works off reading the depth buffer and can only pick elements that light up a pixel, if your "cracks" are composed of lot of tiny line strings it's not going to pick them all up... |
|
I really don't think we can add a new SelectionMethod. SelectTool is public and I know it's been sub-classed. You can provide your own default tool for your application by setting ToolAdmin.defaultToolId to your tool. You could also just write a PrimitiveTool specifically for crack selection (doesn't need to be default tool)? |
