-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Vitest #7165
Introduce Vitest #7165
Conversation
0c34ebc
to
759f256
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving on behalf of core bentley & common
This pull request is now in conflicts. Could you fix it @hl662? 🙏 |
just in case anyone comes back to this pr, dont want you to miss this comment :) |
Co-authored-by: Arun George <aruniverse@users.noreply.github.com>
Continuing off of the work from #6890
For
core-bentley
,core-geometry
,core-common
:@vitest/coverage-istanbul
(I'm open to switching to node's native code coveragev8
too, no opinions on either)chai
,chai-as-promised
,mocha
,nyc
dependenciesOneAtATime tests in core-bentley are skipped for now, haven't finished refactoring them.
Switching the integration tests to vitest is out of the scope of this PR, so just looking at the unit tests within each sub repo instead. We'll investigate this more after.
A couple more issues to circle back to later on as a result of this: #7200 #7201