Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Vitest #7165

Merged
merged 31 commits into from
Sep 27, 2024
Merged

Introduce Vitest #7165

merged 31 commits into from
Sep 27, 2024

Conversation

hl662
Copy link
Contributor

@hl662 hl662 commented Sep 16, 2024

Continuing off of the work from #6890

For core-bentley,core-geometry, core-common:

  • Refactors all tests
  • Uses vitest for coverage as well, needs explicit @vitest/coverage-istanbul (I'm open to switching to node's native code coverage v8 too, no opinions on either)
  • Removed explicit chai, chai-as-promised, mocha, nyc dependencies

OneAtATime tests in core-bentley are skipped for now, haven't finished refactoring them.

Switching the integration tests to vitest is out of the scope of this PR, so just looking at the unit tests within each sub repo instead. We'll investigate this more after.

A couple more issues to circle back to later on as a result of this: #7200 #7201

@hl662 hl662 marked this pull request as ready for review September 26, 2024 16:47
@hl662 hl662 requested a review from a team as a code owner September 26, 2024 16:47
@hl662 hl662 changed the title [Draft] Introduce Vitest Introduce Vitest Sep 26, 2024
Copy link
Member

@aruniverse aruniverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving on behalf of core bentley & common

Copy link
Contributor

mergify bot commented Sep 27, 2024

This pull request is now in conflicts. Could you fix it @hl662? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

@hl662 hl662 enabled auto-merge (squash) September 27, 2024 14:34
@hl662 hl662 merged commit 64fd47f into master Sep 27, 2024
16 checks passed
@hl662 hl662 deleted the nam/vite+vitest branch September 27, 2024 15:09
@aruniverse
Copy link
Member

BTW, just pulled and tried out vitest, and the multithreading is so nice. All core-geometry tests done in 50s. Wow.

just in case anyone comes back to this pr, dont want you to miss this comment :)

naronchen pushed a commit that referenced this pull request Sep 30, 2024
Co-authored-by: Arun George <aruniverse@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants