Do not propagate key down events in editors (#684)

iTwin · Jul 19, 2024 · 298524e · 298524e
1 parent d70aadd
commit 298524e
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 15 deletions.
diff --git a/.changeset/sour-pumas-sell.md b/.changeset/sour-pumas-sell.md
@@ -0,0 +1,5 @@
+---
+"@itwin/presentation-components": patch
+---
+
+Disabled property editors from propagating key down events.
diff --git a/...es/components/src/presentation-components/properties/editors/NavigationPropertyEditor.tsx b/...es/components/src/presentation-components/properties/editors/NavigationPropertyEditor.tsx
@@ -21,10 +21,6 @@ export class NavigationPropertyEditor extends PropertyEditorBase {
     return false;
   }
   // istanbul ignore next
-  public override get containerStopsKeydownPropagation(): boolean {
-    return false;
-  }
-  // istanbul ignore next
   public get reactNode(): React.ReactNode {
     return <NavigationPropertyTargetEditor />;
   }

diff --git a/packages/components/src/presentation-components/properties/editors/NumericPropertyEditor.tsx b/packages/components/src/presentation-components/properties/editors/NumericPropertyEditor.tsx
@@ -26,11 +26,6 @@ export class NumericPropertyEditorBase extends PropertyEditorBase {
     return false;
   }
 
-  // istanbul ignore next
-  public override get containerStopsKeydownPropagation(): boolean {
-    return false;
-  }
-
   // istanbul ignore next
   public override get containerHandlesTab(): boolean {
     return false;

diff --git a/...ages/components/src/presentation-components/properties/editors/QuantityPropertyEditor.tsx b/...ages/components/src/presentation-components/properties/editors/QuantityPropertyEditor.tsx
@@ -19,11 +19,6 @@ export const QuantityEditorName = "presentation-quantity-editor";
  * @internal
  */
 export class QuantityPropertyEditorBase extends PropertyEditorBase {
-  // istanbul ignore next
-  public override get containerStopsKeydownPropagation(): boolean {
-    return false;
-  }
-
   // istanbul ignore next
   public get reactNode(): React.ReactNode {
     return <QuantityPropertyEditor />;

diff --git a/...onents/src/presentation-components/properties/inputs/NavigationPropertyTargetSelector.tsx b/...onents/src/presentation-components/properties/inputs/NavigationPropertyTargetSelector.tsx
@@ -85,7 +85,7 @@ export const NavigationPropertyTargetSelector = forwardRef<PropertyEditorAttribu
         styles={{
           control: () => ({}),
           container: () => ({}),
-          menuPortal: (base) => ({ ...base, zIndex: 9999, width }),
+          menuPortal: (base) => ({ ...base, zIndex: 9999, width, pointerEvents: "auto" }),
           menu: (base) => ({ ...base, margin: 0 }),
           dropdownIndicator: () => ({}),
         }}