Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hierarchies: Cleanup logging, add a learning page #685

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

grigasp
Copy link
Member

@grigasp grigasp commented Jul 19, 2024

Part of #423

@grigasp grigasp requested a review from a team as a code owner July 19, 2024 08:41
Copy link

changeset-bot bot commented Jul 19, 2024

⚠️ No Changeset found

Latest commit: 9167caa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@grigasp grigasp enabled auto-merge (squash) July 19, 2024 08:42
Copy link

github-actions bot commented Jul 19, 2024

Unified selection benchmark

Benchmark suite Current: 9167caa Previous: 01dce3e Deviation Status
hilite 50k elements 1319.61 ms 1238.42 ms 6.5559% 🚨
hilite 50k elements (P95 of main thread blocks) 56 ms 47 ms 19.1489% 🚨
hilite 50k group elements 234.43 ms 234.41 ms 0.0085% 🚨
hilite 50k group elements (P95 of main thread blocks) 31 ms 31 ms 0% 🟰
hilite 1k subjects 48379.42 ms 47623.01 ms 1.5883% 🚨
hilite 1k subjects (P95 of main thread blocks) 22 ms 28 ms -21.4286%
hilite 50k subcategories 277.68 ms 277.19 ms 0.1768% 🚨
hilite 50k subcategories (P95 of main thread blocks) 33 ms 33 ms 0% 🟰
hilite 50k functional 3D elements 25782.47 ms 25884.03 ms -0.3924%
hilite 50k functional 3D elements (P95 of main thread blocks) 34 ms 40 ms -15%
hilite 50k functional 2D elements 6325.22 ms 6148.34 ms 2.8769% 🚨
hilite 50k functional 2D elements (P95 of main thread blocks) 38 ms 34 ms 11.7647% 🚨
compute selection for 50k elements 355.47 ms 342.34 ms 3.8354% 🚨
compute selection for 50k elements (P95 of main thread blocks) 36 ms 35 ms 2.8571% 🚨
compute parent selection for 50k elements 343.93 ms 340.82 ms 0.9125% 🚨
compute parent selection for 50k elements (P95 of main thread blocks) 31 ms 31 ms 0% 🟰
compute top ancestor selection for 50k elements 585.31 ms 565.23 ms 3.5525% 🚨
compute top ancestor selection for 50k elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute category selection for 50k elements 91.01 ms 91.6 ms -0.6441%
compute category selection for 50k elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute model selection for 50k elements 76.6 ms 80.54 ms -4.8920%
compute model selection for 50k elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute functional selection for 50k 3D elements 422.47 ms 403.85 ms 4.6106% 🚨
compute functional selection for 50k 3D elements (P95 of main thread blocks) 31 ms 32 ms -3.1250%
compute parent functional selection for 50k 3D elements 456.48 ms 429.89 ms 6.1853% 🚨
compute parent functional selection for 50k 3D elements (P95 of main thread blocks) 31 ms 31 ms 0% 🟰
compute top ancestor functional selection for 50k 3D elements 1226.08 ms 1140.03 ms 7.5480% 🚨
compute top ancestor functional selection for 50k 3D elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute functional selection for 50k 2D elements 3201.24 ms 2989.85 ms 7.0703% 🚨
compute functional selection for 50k 2D elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute parent functional selection for 50k 2D elements 3243.87 ms 2972.41 ms 9.1327% 🚨
compute parent functional selection for 50k 2D elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute top ancestor functional selection for 50k 2D elements 3272.22 ms 2992.68 ms 9.3408% 🚨
compute top ancestor functional selection for 50k 2D elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

github-actions bot commented Jul 19, 2024

Hierarchies benchmark

Benchmark suite Current: 9167caa Previous: 0864cfe Deviation Status
flat 50k elements list 4052.48 ms 4128.31 ms -1.8368%
flat 50k elements list (P95 of main thread blocks) 72 ms 74 ms -2.7027%
grouping by label 10267.62 ms 9956.76 ms 3.1221% 🚨
grouping by label (P95 of main thread blocks) 69 ms 67 ms 2.9851% 🚨
grouping by class 10293.02 ms 10012.54 ms 2.8013% 🚨
grouping by class (P95 of main thread blocks) 47 ms 42 ms 11.9048% 🚨
grouping by property 10922.59 ms 10507.81 ms 3.9473% 🚨
grouping by property (P95 of main thread blocks) 49 ms 84 ms -41.6667%
grouping by base class (10 classes) 7512.79 ms 7392.71 ms 1.6243% 🚨
grouping by base class (10 classes) (P95 of main thread blocks) 89 ms 79 ms 12.6582% 🚨
grouping by multiple attributes 27601.69 ms 26861.92 ms 2.7540% 🚨
grouping by multiple attributes (P95 of main thread blocks) 68 ms 69 ms -1.4493%
hide if no children required to finalize root, w/o children 46900.06 ms 48529.75 ms -3.3581%
hide if no children required to finalize root, w/o children (P95 of main thread blocks) 39 ms 40 ms -2.5000%
hide if no children required to finalize root, w/ children 148.72 ms 156.05 ms -4.6972%
hide if no children required to finalize root, w/ children (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
models tree initial (Baytown) 41.01 ms 40.8 ms 0.5147% 🚨
models tree initial (Baytown) (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
models tree full (Baytown) 7924.24 ms 7690.68 ms 3.0369% 🚨
models tree full (Baytown) (P95 of main thread blocks) 89 ms 89 ms 0% 🟰

This comment was automatically generated by workflow using github-action-benchmark.

@grigasp grigasp merged commit d70aadd into master Jul 19, 2024
9 checks passed
@grigasp grigasp deleted the hierarchies/learning/logging branch July 19, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants