Cgerman/client cache #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roluk
requested changes
Aug 21, 2023
There was a problem hiding this comment.
This PR increases the number of lines in this repository by 26% (excluding pnpm-lock.yaml). Let's look at how we can compact this down into a more reasonable size.
I have already found some things that can be improved, but I haven't looked at the whole thing yet.
packages/saved-views-client/src/clients/models/clientModels/ImageClientInterfaces.ts
Outdated
Show resolved
Hide resolved
packages/saved-views-client/src/models/ValidatedQueryOrParam.dto.ts
Outdated
Show resolved
Hide resolved
roluk
requested changes
Aug 22, 2023
packages/saved-views-client/src/models/client/SavedViewClientInterfaces.ts
Outdated
Show resolved
Hide resolved
roluk
requested changes
Aug 23, 2023
packages/saved-views-client/src/models/client/CommonClientInterfaces.ts
Outdated
Show resolved
Hide resolved
packages/saved-views-client/src/client/ITwinSavedViewsClient.ts
Outdated
Show resolved
Hide resolved
packages/saved-views-client/src/client/ITwinSavedViewsClient.ts
Outdated
Show resolved
Hide resolved
packages/saved-views-client/src/client/ITwinSavedViewsClient.ts
Outdated
Show resolved
Hide resolved
packages/saved-views-client/src/client/ITwinSavedViewsClient.ts
Outdated
Show resolved
Hide resolved
packages/saved-views-client/src/models/client/SavedViewClientInterfaces.ts
Outdated
Show resolved
Hide resolved
packages/saved-views-client/src/models/savedViews/SavedViewListResponse.dto.ts
Outdated
Show resolved
Hide resolved
packages/saved-views-client/src/models/savedViews/Environment.dto.ts
Outdated
Show resolved
Hide resolved
roluk
reviewed
Aug 24, 2023
packages/saved-views-client/src/client/ITwinSavedViewsClient.ts
Outdated
Show resolved
Hide resolved
roluk
reviewed
Aug 24, 2023
packages/saved-views-client/src/client/ITwinSavedViewsClient.ts
Outdated
Show resolved
Hide resolved
roluk
reviewed
Aug 24, 2023
packages/saved-views-client/src/client/ITwinSavedViewsClient.ts
Outdated
Show resolved
Hide resolved
roluk
reviewed
Aug 24, 2023
packages/saved-views-client/src/client/ITwinSavedViewsClient.ts
Outdated
Show resolved
Hide resolved
roluk
reviewed
Aug 24, 2023
packages/saved-views-client/src/client/ITwinSavedViewsClient.ts
Outdated
Show resolved
Hide resolved
roluk
requested changes
Aug 24, 2023
packages/saved-views-client/src/client/ITwinSavedViewsClient.ts
Outdated
Show resolved
Hide resolved
packages/saved-views-client/src/models/savedViews/ContextRealityModel.dto.ts
Outdated
Show resolved
Hide resolved
packages/saved-views-client/src/models/savedViews/Environment.dto.ts
Outdated
Show resolved
Hide resolved
packages/saved-views-client/src/models/savedViews/MapImagery.dto.ts
Outdated
Show resolved
Hide resolved
packages/saved-views-client/src/models/savedViews/RgbColor.dto.ts
Outdated
Show resolved
Hide resolved
packages/saved-views-client/src/models/savedViews/SavedViewItwinSchemas.dto.ts
Outdated
Show resolved
Hide resolved
packages/saved-views-client/src/models/savedViews/SavedViewListResponse.dto.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Robert Lukasonok <70327485+roluk@users.noreply.github.com>
roluk
requested changes
Sep 6, 2023
packages/saved-views-client/src/client/ITwinSavedViewsClient.ts
Outdated
Show resolved
Hide resolved
packages/saved-views-client/src/client/ITwinSavedViewsClient.ts
Outdated
Show resolved
Hide resolved
packages/saved-views-client/src/client/ITwinSavedViewsClient.ts
Outdated
Show resolved
Hide resolved
packages/saved-views-client/src/models/savedViews/DisplayStyles.ts
Outdated
Show resolved
Hide resolved
packages/saved-views-client/src/models/savedViews/DisplayStyles.ts
Outdated
Show resolved
Hide resolved
roluk
reviewed
Sep 6, 2023
Co-authored-by: Robert Lukasonok <70327485+roluk@users.noreply.github.com>
Co-authored-by: Robert Lukasonok <70327485+roluk@users.noreply.github.com>
roluk
reviewed
Sep 6, 2023
roluk
requested changes
Sep 6, 2023
packages/saved-views-client/src/client/ITwinSavedViewsClient.ts
Outdated
Show resolved
Hide resolved
…views-react into Cgerman/ClientCache
Co-authored-by: Robert Lukasonok <70327485+roluk@users.noreply.github.com>
…views-react into Cgerman/ClientCache
roluk
reviewed
Sep 6, 2023
roluk
requested changes
Sep 8, 2023
packages/saved-views-client/src/client/ITwinSavedViewsClient.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Robert Lukasonok <70327485+roluk@users.noreply.github.com>
…views-react into Cgerman/ClientCache
roluk
requested changes
Sep 11, 2023
Co-authored-by: Robert Lukasonok <70327485+roluk@users.noreply.github.com>
Co-authored-by: Robert Lukasonok <70327485+roluk@users.noreply.github.com>
roluk
approved these changes
Sep 12, 2023
diegopinate
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.