Add height and width measurement tools

[saaaaaally]

Add height and width measurement tools.
Tools are hidden by default and can be enabled with the showHeightTool and showWidthTool flags.

Height Tool:

Width Tool:

[aruniverse]

please update the test viewer to use these new tools

[a-gagnon]

I don't think it's a good idea to add logic to the DistanceMeasurement in order to support a different use-case than what was initially intended.

In my mind, height/width measurements are distance measurements, except that they're constrained to some axis when doing the initial placement. With that in mind, I'd suggest looking at the MeasurePerpendicularTool which does something very similar to what you want to achieve, but still ends up creating a DistanceMeasurement.

If that is not up to your expectations and you want different graphics for the measurement after it's placed, then you could potentially subclass the DistanceMeasurement and override a few methods. I'm thinking of setStartPoint, setEndPoint, setStartEndPoints and decorate for the most part.

[bsy-nicholasw]

@saaaaaally Similar to the other comments, super.writeToJSON will already have written out startPoint/endPoint/showAxes to the json object.

[saaaaaally]

Done

[bsy-nicholasw]

@saaaaaally Should convert this._secondaryLine to an array of XYZProps, calling Point3d's toJSON method. While technically it's valid as written (Point3d instances can mimic XYZProps), it's still good practice to make sure the returned JSON is only primitive data + separate object instances from the original object, to allow callers to mutate it without side effects.

[saaaaaally]

Done

[bsy-nicholasw]

@saaaaaally Using as here doesn't do anything more than satisfy the type checker, which was already satisfied by Point3d being the same shape as XYZProps.

I was suggesting something more like

this._secondaryLine ? this._secondaryLine.map((p) => p.toJSON()) : undefined

[saaaaaally]

Fixed

[bsy-nicholasw]

@saaaaaally iTwin localization allows passing arguments when getting the localized string, e.g. instead of {0} you can have it as {{value}} and pass in a json object with { value: fDistance }. that's more robust than doing a string replace here.

[saaaaaally]

Done

[bsy-nicholasw]

@saaaaaally You don't need to do the string replace still, getLocalizedString's second argument is a TranslationOptions, and the localization library will replace {{value}} automatically when you pass in {value: fDistance}.

https://www.itwinjs.org/learning/frontend/localization/

[saaaaaally]

Fixed

[bsy-nicholasw]

@saaaaaally Can omit the startPoint/endPoint check since that will be taken care of in the super call.

[saaaaaally]

Removed